From e5b0bd1a79f90b7758246655e18ef965a87bcd0b Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 19 Jun 2015 17:15:41 -0700 Subject: Merge to XFA: Do some IWYU cleanups. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1176333002. (cherry picked from commit 0ef0de55657db8a83372ad8eb22d84c5893afc4c) Review URL: https://codereview.chromium.org/1195943005. --- core/src/fxcrt/extension.h | 1 + core/src/fxcrt/fx_arabic.cpp | 3 ++- core/src/fxcrt/fx_arabic.h | 6 ++---- core/src/fxcrt/fx_basic_bstring_unittest.cpp | 4 ++-- core/src/fxcrt/fx_basic_coords.cpp | 3 +++ core/src/fxcrt/fx_basic_gcc.cpp | 3 +++ core/src/fxcrt/fx_basic_maps.cpp | 3 ++- core/src/fxcrt/fx_basic_plex.cpp | 3 ++- core/src/fxcrt/fx_extension.cpp | 2 ++ core/src/fxcrt/fx_ucddata.cpp | 3 ++- core/src/fxcrt/fx_unicode.cpp | 3 ++- core/src/fxcrt/fxcrt_platforms.cpp | 3 ++- core/src/fxcrt/fxcrt_posix.cpp | 3 ++- core/src/fxcrt/fxcrt_windows.cpp | 3 ++- core/src/fxcrt/plex.h | 2 ++ core/src/fxcrt/xml_int.h | 2 ++ 16 files changed, 33 insertions(+), 14 deletions(-) (limited to 'core/src/fxcrt') diff --git a/core/src/fxcrt/extension.h b/core/src/fxcrt/extension.h index 2c084eca2f..09a4f67623 100644 --- a/core/src/fxcrt/extension.h +++ b/core/src/fxcrt/extension.h @@ -7,6 +7,7 @@ #ifndef CORE_SRC_FXCRT_EXTENSION_H_ #define CORE_SRC_FXCRT_EXTENSION_H_ +#include "../../include/fxcrt/fx_basic.h" #include "../../include/fxcrt/fx_safe_types.h" class IFXCRT_FileAccess diff --git a/core/src/fxcrt/fx_arabic.cpp b/core/src/fxcrt/fx_arabic.cpp index fc2ec4158d..95259c71b8 100644 --- a/core/src/fxcrt/fx_arabic.cpp +++ b/core/src/fxcrt/fx_arabic.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_ucd.h" #include "fx_arabic.h" + extern const FX_DWORD gs_FX_TextLayout_CodeProperties[65536]; #ifdef __cplusplus extern "C" { diff --git a/core/src/fxcrt/fx_arabic.h b/core/src/fxcrt/fx_arabic.h index 16938325ec..216547506a 100644 --- a/core/src/fxcrt/fx_arabic.h +++ b/core/src/fxcrt/fx_arabic.h @@ -7,10 +7,8 @@ #ifndef CORE_SRC_FXCRT_FX_ARABIC_H_ #define CORE_SRC_FXCRT_FX_ARABIC_H_ -typedef struct _FX_ARABICCHARRANGE { - FX_WCHAR wStart; - FX_WCHAR wEnd; -} FX_ARABICCHARRANGE; +#include "../../include/fxcrt/fx_arb.h" + class CFX_ArabicChar : public IFX_ArabicChar { public: diff --git a/core/src/fxcrt/fx_basic_bstring_unittest.cpp b/core/src/fxcrt/fx_basic_bstring_unittest.cpp index 9d8f376544..f865602b08 100644 --- a/core/src/fxcrt/fx_basic_bstring_unittest.cpp +++ b/core/src/fxcrt/fx_basic_bstring_unittest.cpp @@ -2,9 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -#include "testing/gtest/include/gtest/gtest.h" #include "../../../testing/fx_string_testhelpers.h" -#include "../../include/fxcrt/fx_basic.h" +#include "../../include/fxcrt/fx_string.h" +#include "testing/gtest/include/gtest/gtest.h" TEST(fxcrt, ByteStringOperatorSubscript) { // CFX_ByteString includes the NUL terminator for non-empty strings. diff --git a/core/src/fxcrt/fx_basic_coords.cpp b/core/src/fxcrt/fx_basic_coords.cpp index 67e2032700..2e830809b8 100644 --- a/core/src/fxcrt/fx_basic_coords.cpp +++ b/core/src/fxcrt/fx_basic_coords.cpp @@ -5,7 +5,10 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include + +#include "../../include/fxcrt/fx_coordinates.h" #include "../../include/fxcrt/fx_ext.h" + void FX_RECT::Normalize() { if (left > right) { diff --git a/core/src/fxcrt/fx_basic_gcc.cpp b/core/src/fxcrt/fx_basic_gcc.cpp index b5a81ad5a9..e4416e95b5 100644 --- a/core/src/fxcrt/fx_basic_gcc.cpp +++ b/core/src/fxcrt/fx_basic_gcc.cpp @@ -5,7 +5,10 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com #include + #include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_string.h" + template T FXSYS_StrToInt(STR_T str) { diff --git a/core/src/fxcrt/fx_basic_maps.cpp b/core/src/fxcrt/fx_basic_maps.cpp index 8a886f88ea..e34acb088d 100644 --- a/core/src/fxcrt/fx_basic_maps.cpp +++ b/core/src/fxcrt/fx_basic_maps.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_basic.h" #include "plex.h" + static void ConstructElement(CFX_ByteString* pNewData) { new (pNewData) CFX_ByteString(); diff --git a/core/src/fxcrt/fx_basic_plex.cpp b/core/src/fxcrt/fx_basic_plex.cpp index 802429600a..c9088bc93d 100644 --- a/core/src/fxcrt/fx_basic_plex.cpp +++ b/core/src/fxcrt/fx_basic_plex.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_basic.h" +#include "../../include/fxcrt/fx_memory.h" #include "plex.h" + CFX_Plex* CFX_Plex::Create(CFX_Plex*& pHead, FX_DWORD nMax, FX_DWORD cbElement) { CFX_Plex* p = (CFX_Plex*)FX_Alloc(uint8_t, sizeof(CFX_Plex) + nMax * cbElement); diff --git a/core/src/fxcrt/fx_extension.cpp b/core/src/fxcrt/fx_extension.cpp index 53ccc5adca..9a165fda93 100644 --- a/core/src/fxcrt/fx_extension.cpp +++ b/core/src/fxcrt/fx_extension.cpp @@ -4,6 +4,7 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com +#include "../../include/fxcrt/fx_basic.h" #include "../../include/fxcrt/fx_ext.h" #include "extension.h" #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_ @@ -11,6 +12,7 @@ #else #include #endif + FX_HFILE FX_File_Open(const CFX_ByteStringC& fileName, FX_DWORD dwMode) { IFXCRT_FileAccess* pFA = FXCRT_FileAccess_Create(); diff --git a/core/src/fxcrt/fx_ucddata.cpp b/core/src/fxcrt/fx_ucddata.cpp index d3ea5cc3be..e632769988 100644 --- a/core/src/fxcrt/fx_ucddata.cpp +++ b/core/src/fxcrt/fx_ucddata.cpp @@ -4,7 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_system.h" + extern const FX_DWORD gs_FX_TextLayout_CodeProperties[65536] = { 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe8ae5, 0xfffe9b5c, 0xfffe9ada, 0xfffe9b1a, 0xfffe9b5b, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9a93, 0xfffe9b53, 0xfffe9b53, 0xfffe9b53, 0xfffe9ad3, diff --git a/core/src/fxcrt/fx_unicode.cpp b/core/src/fxcrt/fx_unicode.cpp index 08a7443289..d66a58a9b3 100644 --- a/core/src/fxcrt/fx_unicode.cpp +++ b/core/src/fxcrt/fx_unicode.cpp @@ -4,7 +4,8 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_ucd.h" + extern const FX_DWORD gs_FX_TextLayout_CodeProperties[65536]; extern const FX_WCHAR gs_FX_TextLayout_VerticalMirror[64]; extern const FX_WCHAR gs_FX_TextLayout_BidiMirror[512]; diff --git a/core/src/fxcrt/fxcrt_platforms.cpp b/core/src/fxcrt/fxcrt_platforms.cpp index cdf24e1fea..617244bc6a 100644 --- a/core/src/fxcrt/fxcrt_platforms.cpp +++ b/core/src/fxcrt/fxcrt_platforms.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_basic.h" #include "fxcrt_platforms.h" + #if (_FXM_PLATFORM_ != _FXM_PLATFORM_WINDOWS_ && _FXM_PLATFORM_ != _FXM_PLATFORM_LINUX_ && _FXM_PLATFORM_ != _FXM_PLATFORM_APPLE_ && _FXM_PLATFORM_ != _FXM_PLATFORM_ANDROID_) IFXCRT_FileAccess* FXCRT_FileAccess_Create() { diff --git a/core/src/fxcrt/fxcrt_posix.cpp b/core/src/fxcrt/fxcrt_posix.cpp index 00c9278525..70df9e8e84 100644 --- a/core/src/fxcrt/fxcrt_posix.cpp +++ b/core/src/fxcrt/fxcrt_posix.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_basic.h" #include "fxcrt_posix.h" + #if _FXM_PLATFORM_ == _FXM_PLATFORM_LINUX_ || _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ || _FXM_PLATFORM_ == _FXM_PLATFORM_ANDROID_ IFXCRT_FileAccess* FXCRT_FileAccess_Create() { diff --git a/core/src/fxcrt/fxcrt_windows.cpp b/core/src/fxcrt/fxcrt_windows.cpp index ac9c60185d..e3dff04413 100644 --- a/core/src/fxcrt/fxcrt_windows.cpp +++ b/core/src/fxcrt/fxcrt_windows.cpp @@ -4,8 +4,9 @@ // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com -#include "../../include/fxcrt/fx_ext.h" +#include "../../include/fxcrt/fx_string.h" #include "fxcrt_windows.h" + #if _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_ FX_BOOL FX_File_Exist(const CFX_ByteStringC& fileName) { diff --git a/core/src/fxcrt/plex.h b/core/src/fxcrt/plex.h index a4ac4f7c48..baf27f5368 100644 --- a/core/src/fxcrt/plex.h +++ b/core/src/fxcrt/plex.h @@ -6,6 +6,8 @@ #ifndef CORE_SRC_FXCRT_PLEX_H_ #define CORE_SRC_FXCRT_PLEX_H_ +#include "../../include/fxcrt/fx_system.h" + struct CFX_Plex { CFX_Plex* pNext; void* data() diff --git a/core/src/fxcrt/xml_int.h b/core/src/fxcrt/xml_int.h index 9469a758cb..109c7a43d2 100644 --- a/core/src/fxcrt/xml_int.h +++ b/core/src/fxcrt/xml_int.h @@ -7,6 +7,8 @@ #ifndef CORE_SRC_FXCRT_XML_INT_H_ #define CORE_SRC_FXCRT_XML_INT_H_ +#include "../../include/fxcrt/fx_stream.h" + class CXML_DataBufAcc : public IFX_BufferRead { public: -- cgit v1.2.3