From ee7412f5aef353e5c6f1a64d0e1708ed926869d9 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Apr 2015 15:00:04 -0700 Subject: Make CFX_WideString::LockBuffer() completely unused. Then remove CFX_{Wide,Byte}String::LockBuffer(). Prelude to a vast simplification. There's an additional copy now in one place, so shoot me. BUG=pdfium:144 R=thestig@chromium.org Review URL: https://codereview.chromium.org/1053613004 --- core/src/fxcrt/fx_basic_bstring.cpp | 9 --------- core/src/fxcrt/fx_basic_wstring.cpp | 9 --------- 2 files changed, 18 deletions(-) (limited to 'core/src/fxcrt') diff --git a/core/src/fxcrt/fx_basic_bstring.cpp b/core/src/fxcrt/fx_basic_bstring.cpp index cda7d1fdd7..961aebe69c 100644 --- a/core/src/fxcrt/fx_basic_bstring.cpp +++ b/core/src/fxcrt/fx_basic_bstring.cpp @@ -341,15 +341,6 @@ void CFX_ByteString::ReleaseBuffer(FX_STRSIZE nNewLength) m_pData->m_nDataLength = nNewLength; m_pData->m_String[nNewLength] = 0; } -FX_LPSTR CFX_ByteString::LockBuffer() -{ - if (m_pData == NULL) { - return NULL; - } - FX_LPSTR lpsz = GetBuffer(0); - m_pData->m_nRefs = -1; - return lpsz; -} void CFX_ByteString::Reserve(FX_STRSIZE len) { GetBuffer(len); diff --git a/core/src/fxcrt/fx_basic_wstring.cpp b/core/src/fxcrt/fx_basic_wstring.cpp index e255aa0779..2ea23e4f19 100644 --- a/core/src/fxcrt/fx_basic_wstring.cpp +++ b/core/src/fxcrt/fx_basic_wstring.cpp @@ -535,15 +535,6 @@ int CFX_WideString::Compare(const CFX_WideString& str) const } return 0; } -FX_LPWSTR CFX_WideString::LockBuffer() -{ - if (m_pData == NULL) { - return NULL; - } - FX_LPWSTR lpsz = GetBuffer(0); - m_pData->m_nRefs = -1; - return lpsz; -} void CFX_WideString::SetAt(FX_STRSIZE nIndex, FX_WCHAR ch) { if (m_pData == NULL) { -- cgit v1.2.3