From 5cd398545141226f082b2f757f23c73303058a83 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Wed, 5 Aug 2015 10:00:59 -0700 Subject: FPDF_Creator can only create file through embedder-supplied callback. Hence, some of the routines taking filename strings are unused. This, in turn allows us to get rid of some other fopen-ishy looking things inside the library. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1264423003 . --- core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp | 20 ------------------ core/src/fxcrt/fx_basic_buffer.cpp | 28 ------------------------- core/src/fxcrt/fx_extension.cpp | 6 ------ 3 files changed, 54 deletions(-) (limited to 'core/src') diff --git a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp index 6f193071de..ff0539c61f 100644 --- a/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp +++ b/core/src/fpdfapi/fpdf_edit/fpdf_edit_create.cpp @@ -2016,26 +2016,6 @@ void CPDF_Creator::Clear() { m_pIDArray = NULL; } } -FX_BOOL CPDF_Creator::Create(const FX_CHAR* filename, FX_DWORD flags) { - if (!m_File.AttachFile(filename)) { - return FALSE; - } - FX_BOOL bRet = Create(flags); - if (!bRet || !(flags & FPDFCREATE_PROGRESSIVE)) { - Clear(); - } - return bRet; -} -FX_BOOL CPDF_Creator::Create(const FX_WCHAR* filename, FX_DWORD flags) { - if (!m_File.AttachFile(filename)) { - return FALSE; - } - FX_BOOL bRet = Create(flags); - if (!bRet || !(flags & FPDFCREATE_PROGRESSIVE)) { - Clear(); - } - return bRet; -} FX_BOOL CPDF_Creator::Create(IFX_StreamWrite* pFile, FX_DWORD flags) { if (!pFile) { return FALSE; diff --git a/core/src/fxcrt/fx_basic_buffer.cpp b/core/src/fxcrt/fx_basic_buffer.cpp index 77884c63c0..deb8133489 100644 --- a/core/src/fxcrt/fx_basic_buffer.cpp +++ b/core/src/fxcrt/fx_basic_buffer.cpp @@ -327,34 +327,6 @@ FX_BOOL CFX_FileBufferArchive::AttachFile(IFX_StreamWrite* pFile, m_bTakeover = bTakeover; return TRUE; } -FX_BOOL CFX_FileBufferArchive::AttachFile(const FX_WCHAR* filename) { - if (!filename) { - return FALSE; - } - if (m_pFile && m_bTakeover) { - m_pFile->Release(); - } - m_pFile = FX_CreateFileWrite(filename); - if (!m_pFile) { - return FALSE; - } - m_bTakeover = TRUE; - return TRUE; -} -FX_BOOL CFX_FileBufferArchive::AttachFile(const FX_CHAR* filename) { - if (!filename) { - return FALSE; - } - if (m_pFile && m_bTakeover) { - m_pFile->Release(); - } - m_pFile = FX_CreateFileWrite(filename); - if (!m_pFile) { - return FALSE; - } - m_bTakeover = TRUE; - return TRUE; -} FX_BOOL CFX_FileBufferArchive::DoWork(const void* pBuf, size_t size) { if (!m_pFile) { return FALSE; diff --git a/core/src/fxcrt/fx_extension.cpp b/core/src/fxcrt/fx_extension.cpp index 0f610d2717..d64a06d08b 100644 --- a/core/src/fxcrt/fx_extension.cpp +++ b/core/src/fxcrt/fx_extension.cpp @@ -36,12 +36,6 @@ IFX_FileStream* FX_CreateFileStream(const FX_WCHAR* filename, } return new CFX_CRTFileStream(pFA); } -IFX_FileWrite* FX_CreateFileWrite(const FX_CHAR* filename) { - return FX_CreateFileStream(filename, FX_FILEMODE_Truncate); -} -IFX_FileWrite* FX_CreateFileWrite(const FX_WCHAR* filename) { - return FX_CreateFileStream(filename, FX_FILEMODE_Truncate); -} IFX_FileRead* FX_CreateFileRead(const FX_CHAR* filename) { return FX_CreateFileStream(filename, FX_FILEMODE_ReadOnly); } -- cgit v1.2.3