From 7a73effb9fe071fbc852b30865d7a332e96fbd56 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 8 Feb 2016 13:39:53 -0800 Subject: Tidy fpdfsave.cpp Remove CFX_PtrArray filelist. Promote ScopedFileStream to .h file and use it. Fix _CAPS names, bool returns, and put in anonymous namespace. FX_CreateMemoryStream() can't return null, so remove checks. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1672153002 . --- core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp | 5 ----- core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp | 5 ----- 2 files changed, 10 deletions(-) (limited to 'core/src') diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp index 6489b1ed98..f170b20d98 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp @@ -81,11 +81,6 @@ bool CanReadFromBitStream(const CFX_BitStream* hStream, } // namespace -// TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal. -// Come up or wait for something better. -using ScopedFileStream = - std::unique_ptr>; - bool IsSignatureDict(const CPDF_Dictionary* pDict) { CPDF_Object* pType = pDict->GetElementValue("Type"); if (!pType) diff --git a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp index 77780b9dcf..e71b19011e 100644 --- a/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp +++ b/core/src/fpdfapi/fpdf_parser/fpdf_parser_parser_unittest.cpp @@ -68,11 +68,6 @@ class CPDF_TestParser : public CPDF_Parser { FRIEND_TEST(fpdf_parser_parser, LoadCrossRefV4); }; -// TODO(thestig) Using unique_ptr with ReleaseDeleter is still not ideal. -// Come up or wait for something better. -using ScopedFileStream = - std::unique_ptr>; - TEST(fpdf_parser_parser, ReadHexString) { { // Empty string. -- cgit v1.2.3