From 224bc5a983a02c0da3ecc0ee55b6c8b1fe500980 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 28 Apr 2016 11:04:51 -0700 Subject: Change bool type to fix warnings. Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches back to FX_BOOL. Attempting to move everything to bool has huge ripple effects. I removed IsINSERTKeyDown as it was always false. Review-Url: https://codereview.chromium.org/1929963002 --- fpdfsdk/cfx_systemhandler.h | 1 - 1 file changed, 1 deletion(-) (limited to 'fpdfsdk/cfx_systemhandler.h') diff --git a/fpdfsdk/cfx_systemhandler.h b/fpdfsdk/cfx_systemhandler.h index ec5735366c..e77120adef 100644 --- a/fpdfsdk/cfx_systemhandler.h +++ b/fpdfsdk/cfx_systemhandler.h @@ -68,7 +68,6 @@ class CFX_SystemHandler { bool IsSHIFTKeyDown(uint32_t nFlag) const; bool IsCTRLKeyDown(uint32_t nFlag) const; bool IsALTKeyDown(uint32_t nFlag) const; - bool IsINSERTKeyDown(uint32_t nFlag) const; FX_SYSTEMTIME GetLocalTime(); -- cgit v1.2.3