From ca03f7a1c654709152a411f665ce38c3626582e8 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 6 Oct 2016 14:53:13 -0400 Subject: Fixup MSan embeddertests The embeddertests were closing the document before the formfill environment. This caused a use-after-free as we try to use the document during formfill destruction. This Cl fixes the destruction order in the embedder tests. As well, a few guards are put in place to keep the system from crashing if the wrong destruction order is called. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/2398063002 . --- fpdfsdk/cpdfsdk_document.h | 1 + 1 file changed, 1 insertion(+) (limited to 'fpdfsdk/cpdfsdk_document.h') diff --git a/fpdfsdk/cpdfsdk_document.h b/fpdfsdk/cpdfsdk_document.h index 3da229cc67..ee140d82ce 100644 --- a/fpdfsdk/cpdfsdk_document.h +++ b/fpdfsdk/cpdfsdk_document.h @@ -54,6 +54,7 @@ class CPDFSDK_Document : public CFX_Observable { #ifdef PDF_ENABLE_XFA // Gets the XFA document directly (XFA-only). CPDFXFA_Document* GetXFADocument() const { return m_pDoc; } + void ResetXFADocument() { m_pDoc = nullptr; } int GetPageViewCount() const { return m_pageMap.size(); } #endif // PDF_ENABLE_XFA -- cgit v1.2.3