From 4f261fffddddd97602e88fe462fef1a18a0b4782 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 10 Oct 2018 18:44:45 +0000 Subject: Get rid of non-const ref parameter in CPDFSDK_InterForm::OnFormat(). Return Optional instead. Change the call stack to accept Optional. Change-Id: I020589fac8a1de4974070268a19b4acad64c4092 Reviewed-on: https://pdfium-review.googlesource.com/c/43601 Commit-Queue: Lei Zhang Reviewed-by: Tom Sepez --- fpdfsdk/cpdfsdk_interform.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'fpdfsdk/cpdfsdk_interform.h') diff --git a/fpdfsdk/cpdfsdk_interform.h b/fpdfsdk/cpdfsdk_interform.h index 1862fdbe2c..2a34c23748 100644 --- a/fpdfsdk/cpdfsdk_interform.h +++ b/fpdfsdk/cpdfsdk_interform.h @@ -16,6 +16,7 @@ #include "core/fxcrt/unowned_ptr.h" #include "core/fxge/fx_dib.h" #include "fpdfsdk/cpdfsdk_widget.h" +#include "third_party/base/optional.h" class CPDF_Dictionary; class CPDF_FormControl; @@ -66,10 +67,10 @@ class CPDFSDK_InterForm final : public IPDF_FormNotify { bool OnKeyStrokeCommit(CPDF_FormField* pFormField, const WideString& csValue); bool OnValidate(CPDF_FormField* pFormField, const WideString& csValue); void OnCalculate(CPDF_FormField* pFormField); - WideString OnFormat(CPDF_FormField* pFormField, bool& bFormatted); + Optional OnFormat(CPDF_FormField* pFormField); void ResetFieldAppearance(CPDF_FormField* pFormField, - const WideString* sValue, + Optional sValue, bool bValueChanged); void UpdateField(CPDF_FormField* pFormField); -- cgit v1.2.3