From 7b1e53c0ef09da360304c6f4397082d09a945a7e Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 15 Sep 2017 15:43:11 -0700 Subject: Use unsigned types for app age, value age in widgets. Then if they roll over, it doesn't matter, since we only check for change. And then we can pull a silly check. Then remove some no-op calls where we didn't use the result. Change-Id: I35ba470b42fb8c32a6984999e0311b21729791ca Reviewed-on: https://pdfium-review.googlesource.com/14210 Commit-Queue: Tom Sepez Reviewed-by: Lei Zhang --- fpdfsdk/cpdfsdk_widget.cpp | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) (limited to 'fpdfsdk/cpdfsdk_widget.cpp') diff --git a/fpdfsdk/cpdfsdk_widget.cpp b/fpdfsdk/cpdfsdk_widget.cpp index 60a4d52657..0183f587cf 100644 --- a/fpdfsdk/cpdfsdk_widget.cpp +++ b/fpdfsdk/cpdfsdk_widget.cpp @@ -57,7 +57,7 @@ CPDFSDK_Widget::CPDFSDK_Widget(CPDF_Annot* pAnnot, CPDFSDK_InterForm* pInterForm) : CPDFSDK_BAAnnot(pAnnot, pPageView), m_pInterForm(pInterForm), - m_nAppAge(0), + m_nAppearanceAge(0), m_nValueAge(0) #ifdef PDF_ENABLE_XFA , @@ -757,9 +757,7 @@ void CPDFSDK_Widget::ResetAppearance(const CFX_WideString* sValue, bool bValueChanged) { SetAppModified(); - m_nAppAge++; - if (m_nAppAge > 999999) - m_nAppAge = 0; + m_nAppearanceAge++; if (bValueChanged) m_nValueAge++; @@ -1048,11 +1046,3 @@ CFX_WideString CPDFSDK_Widget::GetAlternateName() const { CPDF_FormField* pFormField = GetFormField(); return pFormField->GetAlternateName(); } - -int32_t CPDFSDK_Widget::GetAppearanceAge() const { - return m_nAppAge; -} - -int32_t CPDFSDK_Widget::GetValueAge() const { - return m_nValueAge; -} -- cgit v1.2.3