From a30537f8b07492489e81414c9037af90c8b1448e Mon Sep 17 00:00:00 2001 From: dsinclair Date: Wed, 12 Oct 2016 09:12:47 -0700 Subject: Remove unused widget handler overrides This CL removes override points from the widget hander classes. Review-Url: https://codereview.chromium.org/2410193005 --- fpdfsdk/formfiller/cffl_formfiller.cpp | 6 ------ fpdfsdk/formfiller/cffl_formfiller.h | 4 ---- fpdfsdk/formfiller/cffl_interactiveformfiller.cpp | 19 +------------------ fpdfsdk/formfiller/cffl_interactiveformfiller.h | 2 -- fpdfsdk/formfiller/cffl_listbox.cpp | 4 ---- fpdfsdk/formfiller/cffl_listbox.h | 3 --- 6 files changed, 1 insertion(+), 37 deletions(-) (limited to 'fpdfsdk/formfiller') diff --git a/fpdfsdk/formfiller/cffl_formfiller.cpp b/fpdfsdk/formfiller/cffl_formfiller.cpp index e2e99c9a22..86818b1c75 100644 --- a/fpdfsdk/formfiller/cffl_formfiller.cpp +++ b/fpdfsdk/formfiller/cffl_formfiller.cpp @@ -108,12 +108,6 @@ void CFFL_FormFiller::OnDrawDeactive(CPDFSDK_PageView* pPageView, pWidget->DrawAppearance(pDevice, pUser2Device, CPDF_Annot::Normal, nullptr); } -void CFFL_FormFiller::OnCreate(CPDFSDK_Annot* pAnnot) {} - -void CFFL_FormFiller::OnLoad(CPDFSDK_Annot* pAnnot) {} - -void CFFL_FormFiller::OnDelete(CPDFSDK_Annot* pAnnot) {} - void CFFL_FormFiller::OnMouseEnter(CPDFSDK_PageView* pPageView, CPDFSDK_Annot* pAnnot) {} diff --git a/fpdfsdk/formfiller/cffl_formfiller.h b/fpdfsdk/formfiller/cffl_formfiller.h index cfce22fd12..23c3ba7df2 100644 --- a/fpdfsdk/formfiller/cffl_formfiller.h +++ b/fpdfsdk/formfiller/cffl_formfiller.h @@ -34,10 +34,6 @@ class CFFL_FormFiller : public IPWL_Provider, public CPWL_TimerHandler { CFX_RenderDevice* pDevice, CFX_Matrix* pUser2Device); - virtual void OnCreate(CPDFSDK_Annot* pAnnot); - virtual void OnLoad(CPDFSDK_Annot* pAnnot); - virtual void OnDelete(CPDFSDK_Annot* pAnnot); - virtual void OnMouseEnter(CPDFSDK_PageView* pPageView, CPDFSDK_Annot* pAnnot); virtual void OnMouseExit(CPDFSDK_PageView* pPageView, CPDFSDK_Annot* pAnnot); diff --git a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp index 27ad4faeb6..e3a136eebe 100644 --- a/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp +++ b/fpdfsdk/formfiller/cffl_interactiveformfiller.cpp @@ -101,23 +101,7 @@ void CFFL_InteractiveFormFiller::OnDraw(CPDFSDK_PageView* pPageView, pWidget->DrawShadow(pDevice, pPageView); } -void CFFL_InteractiveFormFiller::OnCreate(CPDFSDK_Annot* pAnnot) { - if (CFFL_FormFiller* pFormFiller = GetFormFiller(pAnnot, FALSE)) { - pFormFiller->OnCreate(pAnnot); - } -} - -void CFFL_InteractiveFormFiller::OnLoad(CPDFSDK_Annot* pAnnot) { - if (CFFL_FormFiller* pFormFiller = GetFormFiller(pAnnot, FALSE)) { - pFormFiller->OnLoad(pAnnot); - } -} - void CFFL_InteractiveFormFiller::OnDelete(CPDFSDK_Annot* pAnnot) { - if (CFFL_FormFiller* pFormFiller = GetFormFiller(pAnnot, FALSE)) { - pFormFiller->OnDelete(pAnnot); - } - UnRegisterFormFiller(pAnnot); } @@ -533,9 +517,8 @@ CFFL_FormFiller* CFFL_InteractiveFormFiller::GetFormFiller( } void CFFL_InteractiveFormFiller::RemoveFormFiller(CPDFSDK_Annot* pAnnot) { - if (pAnnot) { + if (pAnnot) UnRegisterFormFiller(pAnnot); - } } void CFFL_InteractiveFormFiller::UnRegisterFormFiller(CPDFSDK_Annot* pAnnot) { diff --git a/fpdfsdk/formfiller/cffl_interactiveformfiller.h b/fpdfsdk/formfiller/cffl_interactiveformfiller.h index 58fafe032d..1a1af44ebb 100644 --- a/fpdfsdk/formfiller/cffl_interactiveformfiller.h +++ b/fpdfsdk/formfiller/cffl_interactiveformfiller.h @@ -33,8 +33,6 @@ class CFFL_InteractiveFormFiller : public IPWL_Filler_Notify { CFX_RenderDevice* pDevice, CFX_Matrix* pUser2Device); - void OnCreate(CPDFSDK_Annot* pAnnot); - void OnLoad(CPDFSDK_Annot* pAnnot); void OnDelete(CPDFSDK_Annot* pAnnot); void OnMouseEnter(CPDFSDK_PageView* pPageView, diff --git a/fpdfsdk/formfiller/cffl_listbox.cpp b/fpdfsdk/formfiller/cffl_listbox.cpp index e4ea65b846..d8331e5027 100644 --- a/fpdfsdk/formfiller/cffl_listbox.cpp +++ b/fpdfsdk/formfiller/cffl_listbox.cpp @@ -164,10 +164,6 @@ void CFFL_ListBox::GetActionData(CPDFSDK_PageView* pPageView, } } -void CFFL_ListBox::SetActionData(CPDFSDK_PageView* pPageView, - CPDF_AAction::AActionType type, - const PDFSDK_FieldAction& fa) {} - void CFFL_ListBox::SaveState(CPDFSDK_PageView* pPageView) { ASSERT(pPageView); diff --git a/fpdfsdk/formfiller/cffl_listbox.h b/fpdfsdk/formfiller/cffl_listbox.h index 12490b8053..eebe2f58ed 100644 --- a/fpdfsdk/formfiller/cffl_listbox.h +++ b/fpdfsdk/formfiller/cffl_listbox.h @@ -31,9 +31,6 @@ class CFFL_ListBox : public CFFL_FormFiller { void GetActionData(CPDFSDK_PageView* pPageView, CPDF_AAction::AActionType type, PDFSDK_FieldAction& fa) override; - void SetActionData(CPDFSDK_PageView* pPageView, - CPDF_AAction::AActionType type, - const PDFSDK_FieldAction& fa) override; void SaveState(CPDFSDK_PageView* pPageView) override; void RestoreState(CPDFSDK_PageView* pPageView) override; CPWL_Wnd* ResetPDFWindow(CPDFSDK_PageView* pPageView, -- cgit v1.2.3