From 2237541071da7f309c16b3033daa4c6be170dca4 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 24 Oct 2018 17:26:50 +0000 Subject: Check CPDFFooObjectFromFPDFPageObject() result. Instead of checking the FPDF_OBJECT itself. Remove redundant checks and fix nits. Change-Id: Id566847d39d16331c08f0b5f3b46431716717b5c Reviewed-on: https://pdfium-review.googlesource.com/c/44535 Reviewed-by: Tom Sepez Commit-Queue: Lei Zhang --- fpdfsdk/fpdf_edittext.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) (limited to 'fpdfsdk/fpdf_edittext.cpp') diff --git a/fpdfsdk/fpdf_edittext.cpp b/fpdfsdk/fpdf_edittext.cpp index 32ea6db607..1c6709f915 100644 --- a/fpdfsdk/fpdf_edittext.cpp +++ b/fpdfsdk/fpdf_edittext.cpp @@ -452,11 +452,7 @@ FPDFPageObj_NewTextObj(FPDF_DOCUMENT document, FPDF_EXPORT FPDF_BOOL FPDF_CALLCONV FPDFText_SetText(FPDF_PAGEOBJECT text_object, FPDF_WIDESTRING text) { - if (!text_object) - return false; - - CPDF_TextObject* pTextObj = - CPDFPageObjectFromFPDFPageObject(text_object)->AsText(); + CPDF_TextObject* pTextObj = CPDFTextObjectFromFPDFPageObject(text_object); if (!pTextObj) return false; @@ -614,9 +610,6 @@ FPDFPageObj_CreateTextObj(FPDF_DOCUMENT document, } FPDF_EXPORT int FPDF_CALLCONV FPDFText_GetTextRenderMode(FPDF_PAGEOBJECT text) { - if (!text) - return -1; - CPDF_TextObject* pTextObj = CPDFTextObjectFromFPDFPageObject(text); if (!pTextObj) return -1; -- cgit v1.2.3