From 76d01feaeec421ebe6005f22de85998220703dd2 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 8 Jun 2018 18:05:58 +0000 Subject: Do not crash if FPDFPage_Get{Media,Crop}Box() gets a NULL out parameter. Change-Id: I4b61d4c7239caaf6081bcba80cc0d8ad61569474 Reviewed-on: https://pdfium-review.googlesource.com/34590 Commit-Queue: Lei Zhang Reviewed-by: Henrique Nakashima --- fpdfsdk/fpdf_transformpage_embeddertest.cpp | 10 ++++++++++ 1 file changed, 10 insertions(+) (limited to 'fpdfsdk/fpdf_transformpage_embeddertest.cpp') diff --git a/fpdfsdk/fpdf_transformpage_embeddertest.cpp b/fpdfsdk/fpdf_transformpage_embeddertest.cpp index d064efee0b..1ebd0f054c 100644 --- a/fpdfsdk/fpdf_transformpage_embeddertest.cpp +++ b/fpdfsdk/fpdf_transformpage_embeddertest.cpp @@ -66,6 +66,16 @@ TEST_F(FPDFTransformEmbedderTest, GetBoundingBoxes) { EXPECT_EQ(60, cropbox_right); EXPECT_EQ(60, cropbox_top); + EXPECT_FALSE(FPDFPage_GetCropBox(page, nullptr, &cropbox_bottom, + &cropbox_right, &cropbox_top)); + EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, nullptr, + &cropbox_right, &cropbox_top)); + EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, &cropbox_bottom, + nullptr, &cropbox_top)); + EXPECT_FALSE(FPDFPage_GetCropBox(page, &cropbox_left, &cropbox_bottom, + &cropbox_right, nullptr)); + EXPECT_FALSE(FPDFPage_GetCropBox(page, nullptr, nullptr, nullptr, nullptr)); + UnloadPage(page); } } -- cgit v1.2.3