From 46abb66cb57d4bc6b9326efd7a0c0e776e594db2 Mon Sep 17 00:00:00 2001 From: Nicolas Pena Date: Wed, 17 May 2017 17:23:22 -0400 Subject: Use more static_cast in fpdfsdk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This CL replaces some reinterpret_cast with static_cast in fpdfsdk. It also removes an obsolete comment in fpdfedit.h Change-Id: I36c29bfcd6382490a8c955b50ccfa4c93ab351c7 Reviewed-on: https://pdfium-review.googlesource.com/5632 Reviewed-by: Lei Zhang Commit-Queue: Nicolás Peña --- fpdfsdk/fpdfedit_embeddertest.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'fpdfsdk/fpdfedit_embeddertest.cpp') diff --git a/fpdfsdk/fpdfedit_embeddertest.cpp b/fpdfsdk/fpdfedit_embeddertest.cpp index ed5fe3e7f8..4559ee3f19 100644 --- a/fpdfsdk/fpdfedit_embeddertest.cpp +++ b/fpdfsdk/fpdfedit_embeddertest.cpp @@ -26,7 +26,7 @@ class FPDFEditEmbeddertest : public EmbedderTest, public TestSaver { protected: FPDF_DOCUMENT CreateNewDocument() { document_ = FPDF_CreateNewDocument(); - cpdf_doc_ = reinterpret_cast(document_); + cpdf_doc_ = static_cast(document_); return document_; } @@ -562,7 +562,7 @@ TEST_F(FPDFEditEmbeddertest, LoadSimpleType1Font) { std::unique_ptr font( FPDFText_LoadFont(document(), data, size, FPDF_FONT_TYPE1, false)); ASSERT_TRUE(font.get()); - CPDF_Font* typed_font = reinterpret_cast(font.get()); + CPDF_Font* typed_font = static_cast(font.get()); EXPECT_TRUE(typed_font->IsType1Font()); CPDF_Dictionary* font_dict = typed_font->GetFontDict(); @@ -591,7 +591,7 @@ TEST_F(FPDFEditEmbeddertest, LoadSimpleTrueTypeFont) { std::unique_ptr font( FPDFText_LoadFont(document(), data, size, FPDF_FONT_TRUETYPE, false)); ASSERT_TRUE(font.get()); - CPDF_Font* typed_font = reinterpret_cast(font.get()); + CPDF_Font* typed_font = static_cast(font.get()); EXPECT_TRUE(typed_font->IsTrueTypeFont()); CPDF_Dictionary* font_dict = typed_font->GetFontDict(); @@ -621,7 +621,7 @@ TEST_F(FPDFEditEmbeddertest, LoadCIDType0Font) { std::unique_ptr font( FPDFText_LoadFont(document(), data, size, FPDF_FONT_TYPE1, 1)); ASSERT_TRUE(font.get()); - CPDF_Font* typed_font = reinterpret_cast(font.get()); + CPDF_Font* typed_font = static_cast(font.get()); EXPECT_TRUE(typed_font->IsCIDFont()); // Check font dictionary entries @@ -663,7 +663,7 @@ TEST_F(FPDFEditEmbeddertest, LoadCIDType2Font) { std::unique_ptr font( FPDFText_LoadFont(document(), data, size, FPDF_FONT_TRUETYPE, 1)); ASSERT_TRUE(font.get()); - CPDF_Font* typed_font = reinterpret_cast(font.get()); + CPDF_Font* typed_font = static_cast(font.get()); EXPECT_TRUE(typed_font->IsCIDFont()); // Check font dictionary entries -- cgit v1.2.3