From 20c94774cc7efb3d90d3181539714f43fdcf01d2 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Mon, 19 Mar 2018 17:44:55 +0000 Subject: Avoid crashing in FPDFText_CountRects() for negative count values. Treat values less than -1 as -1. BUG=chromium:821305 Change-Id: Ieaced045473fa51097400e5af1286f0d3f4d0143 Reviewed-on: https://pdfium-review.googlesource.com/28732 Reviewed-by: Henrique Nakashima Commit-Queue: Lei Zhang --- fpdfsdk/fpdftext_embeddertest.cpp | 3 --- 1 file changed, 3 deletions(-) (limited to 'fpdfsdk/fpdftext_embeddertest.cpp') diff --git a/fpdfsdk/fpdftext_embeddertest.cpp b/fpdfsdk/fpdftext_embeddertest.cpp index c056908148..0cf10f5106 100644 --- a/fpdfsdk/fpdftext_embeddertest.cpp +++ b/fpdfsdk/fpdftext_embeddertest.cpp @@ -725,14 +725,11 @@ TEST_F(FPDFTextEmbeddertest, CountRects) { EXPECT_EQ(2, FPDFText_CountRects(textpage, start, 500)); } -#if 0 - // TODO(thestig): This crashes. Fix and enable. // Now test negative counts. for (int start = 0; start < kHelloWorldEnd; ++start) { EXPECT_EQ(2, FPDFText_CountRects(textpage, start, -100)); EXPECT_EQ(2, FPDFText_CountRects(textpage, start, -2)); } -#endif // Now test larger start values. const int kExpectedLength = strlen(kExpected); -- cgit v1.2.3