From 05d53f0355e9889c43bfa436e985d5643f249d99 Mon Sep 17 00:00:00 2001 From: Wei Li Date: Tue, 29 Mar 2016 16:42:53 -0700 Subject: Code change to avoid signed/unsigned mismatch warnings. This makes pdfium code on Linux and Mac sign-compare warning free. The warning flag will be re-enabled after checking on windows clang build. BUG=pdfium:29 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1841643002 . --- fpdfsdk/fpdfview_embeddertest.cpp | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) (limited to 'fpdfsdk/fpdfview_embeddertest.cpp') diff --git a/fpdfsdk/fpdfview_embeddertest.cpp b/fpdfsdk/fpdfview_embeddertest.cpp index 29eb91ab4d..10fe3aa822 100644 --- a/fpdfsdk/fpdfview_embeddertest.cpp +++ b/fpdfsdk/fpdfview_embeddertest.cpp @@ -88,14 +88,16 @@ TEST_F(FPDFViewEmbeddertest, NamedDests) { buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), 2, fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. // Try to retrieve the forth item with ample buffer. Item is taken // from Dests NameTree but has a vale of the wrong type in named_dests.pdf. buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), 3, fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. // Try to retrieve fifth item with ample buffer. Item taken from the // old-style Dests dictionary object in named_dests.pdf. @@ -120,25 +122,29 @@ TEST_F(FPDFViewEmbeddertest, NamedDests) { buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), 6, fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. // Try to underflow/overflow the integer index. buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), std::numeric_limits::max(), fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), std::numeric_limits::min(), fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. buffer_size = sizeof(fixed_buffer); dest = FPDF_GetNamedDest(document(), -1, fixed_buffer, &buffer_size); EXPECT_EQ(nullptr, dest); - EXPECT_EQ(sizeof(fixed_buffer), buffer_size); // unmodified. + EXPECT_EQ(sizeof(fixed_buffer), + static_cast(buffer_size)); // unmodified. } TEST_F(FPDFViewEmbeddertest, NamedDestsByName) { -- cgit v1.2.3