From a939bfe3e102bfb28b4e8a5d951333d16badf80b Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 22 Sep 2016 13:18:45 -0700 Subject: Make creation of CPDFSDK_Document clearer Move the creation of the CPDFSDK_Document into FPDFDOC_InitFormFillEnvironment instead of hidden inside a Get method in CDPFXFA_Document. Review-Url: https://codereview.chromium.org/2353303004 --- fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp') diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp index 8db16bf4e9..2d74c02d23 100644 --- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp +++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp @@ -191,11 +191,8 @@ void CPDFXFA_Document::RemovePage(CPDFXFA_Page* page) { m_XFAPageList.SetAt(page->GetPageIndex(), nullptr); } -CPDFSDK_Document* CPDFXFA_Document::GetSDKDocument( - CPDFSDK_Environment* pFormFillEnv) { - if (!m_pSDKDoc && pFormFillEnv) - m_pSDKDoc.reset(new CPDFSDK_Document(this, pFormFillEnv)); - return m_pSDKDoc.get(); +void CPDFXFA_Document::SetSDKDoc(std::unique_ptr pSDKDoc) { + m_pSDKDoc.reset(pSDKDoc.release()); } void CPDFXFA_Document::ClearChangeMark() { -- cgit v1.2.3