From 16b703cb504abedbae3e14f69c1ae355363a7ad8 Mon Sep 17 00:00:00 2001 From: tsepez Date: Wed, 26 Oct 2016 08:45:31 -0700 Subject: Fix some bool/int mismatches. Found by winxfa bot when fx_bool defined to bool. Review-Url: https://codereview.chromium.org/2449293002 --- fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'fpdfsdk/fpdfxfa') diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp index 2a2bb3c48d..a5efd50adb 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp +++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp @@ -919,7 +919,6 @@ FX_BOOL CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, return FALSE; } - FPDF_BOOL bRet = TRUE; FPDF_FILEHANDLER* pFileHandler = nullptr; int fileFlag = -1; switch (submit.GetSubmitFormat()) { @@ -966,11 +965,10 @@ FX_BOOL CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, CFX_WideString csBCCAddress; CFX_WideString csSubject; CFX_WideString csMsg; - bRet = MailToInfo(csURL, csToAddress, csCCAddress, csBCCAddress, csSubject, - csMsg); - if (!bRet) + if (!MailToInfo(csURL, csToAddress, csCCAddress, csBCCAddress, csSubject, + csMsg)) { return FALSE; - + } CFX_ByteString bsTo = CFX_WideString(csToAddress).UTF16LE_Encode(); CFX_ByteString bsCC = CFX_WideString(csCCAddress).UTF16LE_Encode(); CFX_ByteString bsBcc = CFX_WideString(csBCCAddress).UTF16LE_Encode(); @@ -997,7 +995,7 @@ FX_BOOL CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, (FPDF_WIDESTRING)bs.GetBuffer(len)); bs.ReleaseBuffer(len); } - return bRet; + return TRUE; } FX_BOOL CPDFXFA_DocEnvironment::SetGlobalProperty( -- cgit v1.2.3