From 55865454c43fbc3b163cff166544ba0a060dcbc4 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Aug 2018 20:18:04 +0000 Subject: The final game: mark everything final. Then revert the ones that break compilation. Fix one IWYU noticed during presubmit. Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7 Reviewed-on: https://pdfium-review.googlesource.com/41470 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- fpdfsdk/fpdfxfa/cpdfxfa_context.h | 4 ++-- fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h | 2 +- fpdfsdk/fpdfxfa/cpdfxfa_page.h | 2 +- fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp | 2 +- fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) (limited to 'fpdfsdk/fpdfxfa') diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.h b/fpdfsdk/fpdfxfa/cpdfxfa_context.h index 9648e8e299..887f06d431 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_context.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.h @@ -33,8 +33,8 @@ enum LoadStatus { FXFA_LOADSTATUS_CLOSED }; -class CPDFXFA_Context : public CPDF_Document::Extension, - public IXFA_AppProvider { +class CPDFXFA_Context final : public CPDF_Document::Extension, + public IXFA_AppProvider { public: explicit CPDFXFA_Context(CPDF_Document* pPDFDoc); ~CPDFXFA_Context() override; diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h index dfc51e03e2..0613fc3bc9 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h @@ -14,7 +14,7 @@ class CPDFXFA_Context; -class CPDFXFA_DocEnvironment : public IXFA_DocEnvironment { +class CPDFXFA_DocEnvironment final : public IXFA_DocEnvironment { public: explicit CPDFXFA_DocEnvironment(CPDFXFA_Context*); ~CPDFXFA_DocEnvironment() override; diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_page.h b/fpdfsdk/fpdfxfa/cpdfxfa_page.h index b660869e68..769bdaa792 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_page.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_page.h @@ -22,7 +22,7 @@ class CPDF_Dictionary; class CPDFXFA_Context; class CXFA_FFPageView; -class CPDFXFA_Page : public IPDF_Page { +class CPDFXFA_Page final : public IPDF_Page { public: template friend RetainPtr pdfium::MakeRetain(Args&&... args); diff --git a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp index adba260041..890139498c 100644 --- a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp +++ b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.cpp @@ -14,7 +14,7 @@ namespace { -class CFWL_FWLAdapterTimerInfo : public CFWL_TimerInfo { +class CFWL_FWLAdapterTimerInfo final : public CFWL_TimerInfo { public: CFWL_FWLAdapterTimerInfo(IFWL_AdapterTimerMgr* mgr, int32_t event, diff --git a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h index 96ccc1ce7e..8bca0bdd28 100644 --- a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h +++ b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h @@ -15,7 +15,7 @@ #include "xfa/fwl/cfwl_timerinfo.h" #include "xfa/fwl/ifwl_adaptertimermgr.h" -class CXFA_FWLAdapterTimerMgr : public IFWL_AdapterTimerMgr { +class CXFA_FWLAdapterTimerMgr final : public IFWL_AdapterTimerMgr { public: explicit CXFA_FWLAdapterTimerMgr(CPDFSDK_FormFillEnvironment* pFormFillEnv); ~CXFA_FWLAdapterTimerMgr() override; -- cgit v1.2.3