From 85c8e7f788512ce5b5b43cd816e8091b57c3d5e7 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Mon, 21 Nov 2016 13:50:32 -0500 Subject: Fixup lint flags. The -build/include setting was masking out build/include_what_you_use. This CL restores them, fixes any build errors, and adds NOLINT as needed. As well, the runtime/explicit and runtime/printf flags are aslo enabled and NOLINT'd. lint cleanups Change-Id: Ib013b3eb29c8d0e48cad74c5df9028684130719f Reviewed-on: https://pdfium-review.googlesource.com/2030 Reviewed-by: Tom Sepez --- fpdfsdk/fpdfxfa/cpdfxfa_context.cpp | 2 ++ fpdfsdk/fpdfxfa/cpdfxfa_context.h | 2 +- fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h | 2 +- fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h | 2 +- 4 files changed, 5 insertions(+), 3 deletions(-) (limited to 'fpdfsdk/fpdfxfa') diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp index b239d70695..7945786070 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp +++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.cpp @@ -6,6 +6,8 @@ #include "fpdfsdk/fpdfxfa/cpdfxfa_context.h" +#include + #include "core/fpdfapi/parser/cpdf_document.h" #include "fpdfsdk/cpdfsdk_formfillenvironment.h" #include "fpdfsdk/cpdfsdk_interform.h" diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_context.h b/fpdfsdk/fpdfxfa/cpdfxfa_context.h index 98161e2b3e..2cd2b439d3 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_context.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_context.h @@ -29,7 +29,7 @@ enum LoadStatus { class CPDFXFA_Context : public IXFA_AppProvider { public: - CPDFXFA_Context(std::unique_ptr pPDFDoc); + explicit CPDFXFA_Context(std::unique_ptr pPDFDoc); ~CPDFXFA_Context() override; bool LoadXFADoc(); diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h index 8909cf6429..a7d41a88c8 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h +++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.h @@ -15,7 +15,7 @@ class IJS_Context; class CPDFXFA_DocEnvironment : public IXFA_DocEnvironment { public: - CPDFXFA_DocEnvironment(CPDFXFA_Context*); + explicit CPDFXFA_DocEnvironment(CPDFXFA_Context*); ~CPDFXFA_DocEnvironment() override; // IXFA_DocEnvironment diff --git a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h index 5b0b414214..9f529fcbc8 100644 --- a/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h +++ b/fpdfsdk/fpdfxfa/cxfa_fwladaptertimermgr.h @@ -17,7 +17,7 @@ struct CFWL_TimerInfo; class CXFA_FWLAdapterTimerMgr : public IFWL_AdapterTimerMgr { public: - CXFA_FWLAdapterTimerMgr(CPDFSDK_FormFillEnvironment* pFormFillEnv) + explicit CXFA_FWLAdapterTimerMgr(CPDFSDK_FormFillEnvironment* pFormFillEnv) : m_pFormFillEnv(pFormFillEnv) {} void Start(IFWL_Timer* pTimer, -- cgit v1.2.3