From ff46aaf499edcf153ee2f57c7016587aa96dcfa0 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Jul 2015 11:55:29 -0700 Subject: FX Bool considered harmful, part 3 Try to reland this patch after fixing underlying issues that caused it to be reverted. fx_system.h is the only manual edit. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1258093002 . --- fpdfsdk/include/javascript/JS_Runtime.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'fpdfsdk/include/javascript/JS_Runtime.h') diff --git a/fpdfsdk/include/javascript/JS_Runtime.h b/fpdfsdk/include/javascript/JS_Runtime.h index 8fdfa8b733..b9ad6efc47 100644 --- a/fpdfsdk/include/javascript/JS_Runtime.h +++ b/fpdfsdk/include/javascript/JS_Runtime.h @@ -44,15 +44,15 @@ public: CPDFDoc_Environment * GetReaderApp(){return m_pApp;} - FX_BOOL InitJSObjects(); + bool InitJSObjects(); - FX_BOOL AddEventToLoop(const CFX_WideString& sTargetName, JS_EVENT_T eEventType); + bool AddEventToLoop(const CFX_WideString& sTargetName, JS_EVENT_T eEventType); void RemoveEventInLoop(const CFX_WideString& sTargetName, JS_EVENT_T eEventType); void RemoveEventsInLoop(CJS_FieldEvent* pStart); - void BeginBlock(){m_bBlocking = TRUE;} - void EndBlock(){m_bBlocking = FALSE;} - FX_BOOL IsBlocking(){return m_bBlocking;} + void BeginBlock(){m_bBlocking = true;} + void EndBlock(){m_bBlocking = false;} + bool IsBlocking(){return m_bBlocking;} operator IJS_Runtime*() {return (IJS_Runtime*)m_isolate;} v8::Isolate* GetIsolate(){return m_isolate;}; @@ -63,7 +63,7 @@ protected: CFX_ArrayTemplate m_ContextArray; CPDFDoc_Environment* m_pApp; CPDFSDK_Document* m_pDocument; - FX_BOOL m_bBlocking; + bool m_bBlocking; CJS_FieldEvent* m_pFieldEventPath; v8::Isolate* m_isolate; -- cgit v1.2.3