From ff46aaf499edcf153ee2f57c7016587aa96dcfa0 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Jul 2015 11:55:29 -0700 Subject: FX Bool considered harmful, part 3 Try to reland this patch after fixing underlying issues that caused it to be reverted. fx_system.h is the only manual edit. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1258093002 . --- fpdfsdk/include/javascript/JS_Value.h | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'fpdfsdk/include/javascript/JS_Value.h') diff --git a/fpdfsdk/include/javascript/JS_Value.h b/fpdfsdk/include/javascript/JS_Value.h index 6186817fa5..035cef064d 100644 --- a/fpdfsdk/include/javascript/JS_Value.h +++ b/fpdfsdk/include/javascript/JS_Value.h @@ -63,12 +63,12 @@ public: void operator = (const FX_CHAR* pStr); void operator = (CJS_Value value); - FX_BOOL IsArrayObject() const; - FX_BOOL IsDateObject() const; + bool IsArrayObject() const; + bool IsDateObject() const; FXJSVALUETYPE GetType() const; - FX_BOOL ConvertToArray(CJS_Array &) const; - FX_BOOL ConvertToDate(CJS_Date &) const; + bool ConvertToArray(CJS_Array &) const; + bool ConvertToDate(CJS_Date &) const; v8::Isolate* GetIsolate() {return m_isolate;} protected: @@ -95,8 +95,8 @@ public: CJS_PropValue(v8::Isolate* isolate); ~CJS_PropValue(); public: - FX_BOOL IsSetting(); - FX_BOOL IsGetting(); + bool IsSetting(); + bool IsGetting(); void operator<<(int); void operator>>(int&) const; void operator<<(bool); @@ -122,7 +122,7 @@ public: void StartSetting(); void StartGetting(); private: - FX_BOOL m_bIsSetting; + bool m_bIsSetting; }; class CJS_Array @@ -135,7 +135,7 @@ public: void GetElement(unsigned index,CJS_Value &value); void SetElement(unsigned index,CJS_Value value); int GetLength(); - FX_BOOL IsAttached(); + bool IsAttached(); operator v8::Local(); v8::Isolate* GetIsolate() {return m_isolate;} @@ -179,7 +179,7 @@ public: static double MakeDate(int year, int mon, int mday,int hour, int min, int sec,int ms); - FX_BOOL IsValidDate(); + bool IsValidDate(); protected: v8::Local m_pDate; -- cgit v1.2.3