From b9e0190938f62bf21df078e47190a62ba33ddab2 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 9 Jan 2015 10:46:50 -0800 Subject: Fix -Wnon-virtual-dtor compiler warnings. This is done by explicitly adding a virtual dtor to interface classes, since the cost is small given that there are already virtual functions. The exceptions are for classes that have a Release() or Delete() method, in which case it is non-virtual and protected to indicate that the virtual class is never the deletion point. BUG= R=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/810883005 --- fpdfsdk/include/pdfwindow/PWL_Wnd.h | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'fpdfsdk/include/pdfwindow/PWL_Wnd.h') diff --git a/fpdfsdk/include/pdfwindow/PWL_Wnd.h b/fpdfsdk/include/pdfwindow/PWL_Wnd.h index c3dd9b7a70..51a3058993 100644 --- a/fpdfsdk/include/pdfwindow/PWL_Wnd.h +++ b/fpdfsdk/include/pdfwindow/PWL_Wnd.h @@ -168,6 +168,7 @@ inline FX_BOOL operator != (const CPWL_Color &c1, const CPWL_Color &c2) class IPWL_SpellCheck { public: + virtual ~IPWL_SpellCheck() { } virtual FX_BOOL CheckWord(FX_LPCSTR sWord) = 0; virtual void SuggestWords(FX_LPCSTR sWord, CFX_ByteStringArray & sSuggest) = 0; }; @@ -175,6 +176,8 @@ public: class IPWL_Provider { public: + virtual ~IPWL_Provider() { } + //get a matrix which map user space to CWnd client space virtual CPDF_Matrix GetWindowMatrix(void* pAttachedData) = 0; @@ -193,6 +196,7 @@ public: class IPWL_FocusHandler { public: + virtual ~IPWL_FocusHandler() { } virtual void OnSetFocus(CPWL_Wnd* pWnd) = 0; virtual void OnKillFocus(CPWL_Wnd* pWnd) = 0; }; -- cgit v1.2.3