From b9e0190938f62bf21df078e47190a62ba33ddab2 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 9 Jan 2015 10:46:50 -0800 Subject: Fix -Wnon-virtual-dtor compiler warnings. This is done by explicitly adding a virtual dtor to interface classes, since the cost is small given that there are already virtual functions. The exceptions are for classes that have a Release() or Delete() method, in which case it is non-virtual and protected to indicate that the virtual class is never the deletion point. BUG= R=brucedawson@chromium.org, thestig@chromium.org Review URL: https://codereview.chromium.org/810883005 --- fpdfsdk/include/pdfwindow/PWL_Edit.h | 1 + fpdfsdk/include/pdfwindow/PWL_EditCtrl.h | 1 + fpdfsdk/include/pdfwindow/PWL_IconList.h | 1 + fpdfsdk/include/pdfwindow/PWL_Note.h | 3 +++ fpdfsdk/include/pdfwindow/PWL_Wnd.h | 4 ++++ 5 files changed, 10 insertions(+) (limited to 'fpdfsdk/include/pdfwindow') diff --git a/fpdfsdk/include/pdfwindow/PWL_Edit.h b/fpdfsdk/include/pdfwindow/PWL_Edit.h index d86cb77d2c..7a4caaa6ef 100644 --- a/fpdfsdk/include/pdfwindow/PWL_Edit.h +++ b/fpdfsdk/include/pdfwindow/PWL_Edit.h @@ -14,6 +14,7 @@ class IPWL_SpellCheck; class IPWL_Filler_Notify { public: + virtual ~IPWL_Filler_Notify() { } virtual void QueryWherePopup(void* pPrivateData, FX_FLOAT fPopupMin,FX_FLOAT fPopupMax, FX_INT32 & nRet, FX_FLOAT & fPopupRet) = 0; //nRet: (0:bottom 1:top) virtual void OnBeforeKeyStroke(FX_BOOL bEditOrList, void* pPrivateData, FX_INT32 nKeyCode, diff --git a/fpdfsdk/include/pdfwindow/PWL_EditCtrl.h b/fpdfsdk/include/pdfwindow/PWL_EditCtrl.h index b13d5e1e79..c9d87b217c 100644 --- a/fpdfsdk/include/pdfwindow/PWL_EditCtrl.h +++ b/fpdfsdk/include/pdfwindow/PWL_EditCtrl.h @@ -30,6 +30,7 @@ class CPWL_Edit; class IPWL_Edit_Notify { public: + virtual ~IPWL_Edit_Notify() { } //when the position of caret is changed in edit virtual void OnCaretMove(FX_INT32 x1, FX_INT32 y1, FX_INT32 x2, FX_INT32 y2) {} virtual void OnContentChange(const CPDF_Rect& rcContent){} diff --git a/fpdfsdk/include/pdfwindow/PWL_IconList.h b/fpdfsdk/include/pdfwindow/PWL_IconList.h index effabd0713..6b3d577504 100644 --- a/fpdfsdk/include/pdfwindow/PWL_IconList.h +++ b/fpdfsdk/include/pdfwindow/PWL_IconList.h @@ -16,6 +16,7 @@ class CPWL_Label; class IPWL_IconList_Notify { public: + virtual ~IPWL_IconList_Notify() { } virtual void OnNoteListSelChanged(FX_INT32 nItemIndex) = 0; }; diff --git a/fpdfsdk/include/pdfwindow/PWL_Note.h b/fpdfsdk/include/pdfwindow/PWL_Note.h index b3f73581b1..125271f48f 100644 --- a/fpdfsdk/include/pdfwindow/PWL_Note.h +++ b/fpdfsdk/include/pdfwindow/PWL_Note.h @@ -27,6 +27,7 @@ class IPopup_Note; class IPWL_NoteNotify { public: + virtual ~IPWL_NoteNotify() { } virtual void OnNoteMove(const FX_RECT& rtWin) = 0; virtual void OnNoteShow(FX_BOOL bShow) = 0; virtual void OnNoteActivate(FX_BOOL bActive) = 0; @@ -45,12 +46,14 @@ public: class IPWL_NoteHandler { public: + virtual ~IPWL_NoteHandler() { } virtual void OnNoteColorChanged(const CPWL_Color& color) = 0; }; class IPWL_NoteItem { public: + virtual ~IPWL_NoteItem() { } virtual void SetPrivateData(void* pData) = 0; virtual void SetBkColor(const CPWL_Color& color) = 0; virtual void SetSubjectName(const CFX_WideString& sName) = 0; diff --git a/fpdfsdk/include/pdfwindow/PWL_Wnd.h b/fpdfsdk/include/pdfwindow/PWL_Wnd.h index c3dd9b7a70..51a3058993 100644 --- a/fpdfsdk/include/pdfwindow/PWL_Wnd.h +++ b/fpdfsdk/include/pdfwindow/PWL_Wnd.h @@ -168,6 +168,7 @@ inline FX_BOOL operator != (const CPWL_Color &c1, const CPWL_Color &c2) class IPWL_SpellCheck { public: + virtual ~IPWL_SpellCheck() { } virtual FX_BOOL CheckWord(FX_LPCSTR sWord) = 0; virtual void SuggestWords(FX_LPCSTR sWord, CFX_ByteStringArray & sSuggest) = 0; }; @@ -175,6 +176,8 @@ public: class IPWL_Provider { public: + virtual ~IPWL_Provider() { } + //get a matrix which map user space to CWnd client space virtual CPDF_Matrix GetWindowMatrix(void* pAttachedData) = 0; @@ -193,6 +196,7 @@ public: class IPWL_FocusHandler { public: + virtual ~IPWL_FocusHandler() { } virtual void OnSetFocus(CPWL_Wnd* pWnd) = 0; virtual void OnKillFocus(CPWL_Wnd* pWnd) = 0; }; -- cgit v1.2.3