From 224bc5a983a02c0da3ecc0ee55b6c8b1fe500980 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 28 Apr 2016 11:04:51 -0700 Subject: Change bool type to fix warnings. Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches back to FX_BOOL. Attempting to move everything to bool has huge ripple effects. I removed IsINSERTKeyDown as it was always false. Review-Url: https://codereview.chromium.org/1929963002 --- fpdfsdk/include/fsdk_mgr.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'fpdfsdk/include') diff --git a/fpdfsdk/include/fsdk_mgr.h b/fpdfsdk/include/fsdk_mgr.h index 8fbc0d75e9..cd89a925ab 100644 --- a/fpdfsdk/include/fsdk_mgr.h +++ b/fpdfsdk/include/fsdk_mgr.h @@ -115,8 +115,6 @@ class CPDFDoc_Environment final { return (nFlag & FWL_EVENTFLAG_AltKey) != 0; } - FX_BOOL FFI_IsINSERTKeyDown(uint32_t nFlag) const { return FALSE; } - FPDF_PAGE FFI_GetPage(FPDF_DOCUMENT document, int nPageIndex) { if (m_pInfo && m_pInfo->FFI_GetPage) return m_pInfo->FFI_GetPage(m_pInfo, document, nPageIndex); -- cgit v1.2.3