From b4694249b336d1c0bea9222880b49dcf9284791d Mon Sep 17 00:00:00 2001 From: tsepez Date: Mon, 15 Aug 2016 16:44:55 -0700 Subject: Push v8::Isolate into CFXJS_Engine class Nearly all the "loose" functions in FXJS become methods on the CFJXS_Engine. This is the "missing link" wrt some layering violatons that have been around forever. We can stop passing &m_ variables from CJS_ down into FXJS Initialization as a result. Review-Url: https://codereview.chromium.org/2245863002 --- fpdfsdk/javascript/Document.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'fpdfsdk/javascript/Document.h') diff --git a/fpdfsdk/javascript/Document.h b/fpdfsdk/javascript/Document.h index 873f70e327..1c20ac4221 100644 --- a/fpdfsdk/javascript/Document.h +++ b/fpdfsdk/javascript/Document.h @@ -269,7 +269,6 @@ class Document : public CJS_EmbedObj { CPDFSDK_Document* GetReaderDoc(); void AddDelayData(CJS_DelayData* pData); void DoFieldDelay(const CFX_WideString& sFieldName, int nControlIndex); - void SetIsolate(v8::Isolate* isolate) { m_isolate = isolate; } CJS_Document* GetCJSDoc() const; private: @@ -282,12 +281,11 @@ class Document : public CJS_EmbedObj { const CFX_ByteString& propName, CFX_WideString& sError); - v8::Isolate* m_isolate; - std::list> m_IconList; CPDFSDK_Document* m_pDocument; CFX_WideString m_cwBaseURL; - bool m_bDelay; std::list> m_DelayData; + std::list> m_IconList; + bool m_bDelay; }; class CJS_Document : public CJS_Object { -- cgit v1.2.3