From cbe23dbdff3f6e41843fd99cbf615000b52727ed Mon Sep 17 00:00:00 2001 From: dan sinclair Date: Thu, 19 Oct 2017 14:29:33 -0400 Subject: Refactoring JS Callbacks. This CL updates the fpdfsdk/javascript callbacks to have explicit get/set methods instead of one method which worked differently depending on the mode. This allows better ownership of the passed in params, (get takes a * and set takes a const&). The Value object was changed to have To* and Set methods to make the code clearer compared to the operator<< and operator>> overloading. Bug: Change-Id: Id6ff20a4e3252adfd0a78b643e50b9f095085018 Reviewed-on: https://pdfium-review.googlesource.com/16330 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- fpdfsdk/javascript/global.h | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'fpdfsdk/javascript/global.h') diff --git a/fpdfsdk/javascript/global.h b/fpdfsdk/javascript/global.h index 5005b2aeed..c741a1a20f 100644 --- a/fpdfsdk/javascript/global.h +++ b/fpdfsdk/javascript/global.h @@ -41,13 +41,13 @@ class JSGlobalAlternate : public CJS_EmbedObj { CJS_Value& vRet, WideString& sError); bool QueryProperty(const wchar_t* propname); - bool DoProperty(CJS_Runtime* pRuntime, - const wchar_t* propname, - CJS_PropValue& vp, - WideString& sError); - bool DelProperty(CJS_Runtime* pRuntime, + bool GetProperty(CJS_Runtime* pRuntime, const wchar_t* propname, - WideString& sError); + CJS_PropValue* vp); + bool SetProperty(CJS_Runtime* pRuntime, + const wchar_t* propname, + const CJS_PropValue& vp); + bool DelProperty(CJS_Runtime* pRuntime, const wchar_t* propname); void Initial(CPDFSDK_FormFillEnvironment* pFormFillEnv); private: -- cgit v1.2.3