From 977c2a048e02dd3a9563be0c2c6ee62435e134c1 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Thu, 26 Oct 2017 12:36:18 -0400 Subject: Remove methods for empty const/method/property arrays This CL cleans up the methods and arrays for constants, methods and property definitions which are empty. Change-Id: I4a4d85cc139075de77d84a40182bd00341c31818 Reviewed-on: https://pdfium-review.googlesource.com/16910 Reviewed-by: Tom Sepez Commit-Queue: dsinclair --- fpdfsdk/javascript/util.cpp | 24 ------------------------ 1 file changed, 24 deletions(-) (limited to 'fpdfsdk/javascript/util.cpp') diff --git a/fpdfsdk/javascript/util.cpp b/fpdfsdk/javascript/util.cpp index a0d0a57542..08846c18b1 100644 --- a/fpdfsdk/javascript/util.cpp +++ b/fpdfsdk/javascript/util.cpp @@ -28,10 +28,6 @@ #include #endif -JSConstSpec CJS_Util::ConstSpecs[] = {{0, JSConstSpec::Number, 0, 0}}; - -JSPropertySpec CJS_Util::PropertySpecs[] = {{0, 0, 0}}; - JSMethodSpec CJS_Util::MethodSpecs[] = { {"printd", printd_static}, {"printf", printf_static}, {"printx", printx_static}, {"scand", scand_static}, @@ -40,16 +36,6 @@ JSMethodSpec CJS_Util::MethodSpecs[] = { const char* CJS_Util::g_pClassName = "util"; int CJS_Util::g_nObjDefnID = -1; -void CJS_Util::DefineConsts(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(ConstSpecs) - 1; ++i) { - pEngine->DefineObjConst( - g_nObjDefnID, ConstSpecs[i].pName, - ConstSpecs[i].eType == JSConstSpec::Number - ? pEngine->NewNumber(ConstSpecs[i].number).As() - : pEngine->NewString(ConstSpecs[i].pStr).As()); - } -} - void CJS_Util::JSConstructor(CFXJS_Engine* pEngine, v8::Local obj) { CJS_Object* pObj = new CJS_Util(obj); pObj->SetEmbedObject(new util(pObj)); @@ -61,14 +47,6 @@ void CJS_Util::JSDestructor(CFXJS_Engine* pEngine, v8::Local obj) { delete static_cast(pEngine->GetObjectPrivate(obj)); } -void CJS_Util::DefineProps(CFXJS_Engine* pEngine) { - for (size_t i = 0; i < FX_ArraySize(PropertySpecs) - 1; ++i) { - pEngine->DefineObjProperty(g_nObjDefnID, PropertySpecs[i].pName, - PropertySpecs[i].pPropGet, - PropertySpecs[i].pPropPut); - } -} - void CJS_Util::DefineMethods(CFXJS_Engine* pEngine) { for (size_t i = 0; i < FX_ArraySize(MethodSpecs) - 1; ++i) { pEngine->DefineObjMethod(g_nObjDefnID, MethodSpecs[i].pName, @@ -79,8 +57,6 @@ void CJS_Util::DefineMethods(CFXJS_Engine* pEngine) { void CJS_Util::DefineJSObjects(CFXJS_Engine* pEngine, FXJSOBJTYPE eObjType) { g_nObjDefnID = pEngine->DefineObj(CJS_Util::g_pClassName, eObjType, JSConstructor, JSDestructor); - DefineConsts(pEngine); - DefineProps(pEngine); DefineMethods(pEngine); } -- cgit v1.2.3