From 45b9ae18668e996f90780880dd691d69fa13cbe1 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 18 May 2017 08:34:03 -0700 Subject: Revert "Smells like a leak in PWL_ComboBox.cpp" This reverts commit b084c1f615e9b5d82a36aeedcff2339b7ac91265. Reason for revert: new crashes. BUG=723415 TBR=dsinclair@chromium.org Change-Id: I5194170f74a5781dad213d08a28e574eb6d56156 Reviewed-on: https://pdfium-review.googlesource.com/5655 Commit-Queue: Tom Sepez Reviewed-by: dsinclair Reviewed-by: Tom Sepez --- fpdfsdk/pdfwindow/PWL_ComboBox.h | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'fpdfsdk/pdfwindow/PWL_ComboBox.h') diff --git a/fpdfsdk/pdfwindow/PWL_ComboBox.h b/fpdfsdk/pdfwindow/PWL_ComboBox.h index 19d9ab2a04..0dfb3bd86b 100644 --- a/fpdfsdk/pdfwindow/PWL_ComboBox.h +++ b/fpdfsdk/pdfwindow/PWL_ComboBox.h @@ -52,7 +52,7 @@ class CPWL_ComboBox : public CPWL_Wnd { CPWL_ComboBox(); ~CPWL_ComboBox() override; - CPWL_Edit* GetEdit() const { return m_pEdit.get(); } + CPWL_Edit* GetEdit() const { return m_pEdit; } // CPWL_Wnd: CFX_ByteString GetClassName() const override; @@ -93,9 +93,9 @@ class CPWL_ComboBox : public CPWL_Wnd { void CreateListBox(const PWL_CREATEPARAM& cp); void SetPopup(bool bPopup); - std::unique_ptr m_pEdit; - std::unique_ptr m_pButton; - std::unique_ptr m_pList; + CPWL_CBEdit* m_pEdit; + CPWL_CBButton* m_pButton; + CPWL_CBListBox* m_pList; bool m_bPopup; CFX_FloatRect m_rcOldWindow; int32_t m_nPopupWhere; -- cgit v1.2.3