From b084c1f615e9b5d82a36aeedcff2339b7ac91265 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Fri, 12 May 2017 14:04:06 -0700 Subject: Smells like a leak in PWL_ComboBox.cpp Change-Id: I519d79b2b22d2b947c546c6285195b8ca52f4993 Reviewed-on: https://pdfium-review.googlesource.com/5471 Commit-Queue: dsinclair Reviewed-by: dsinclair --- fpdfsdk/pdfwindow/PWL_ComboBox.h | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'fpdfsdk/pdfwindow/PWL_ComboBox.h') diff --git a/fpdfsdk/pdfwindow/PWL_ComboBox.h b/fpdfsdk/pdfwindow/PWL_ComboBox.h index e1a8df7561..a687eb8e94 100644 --- a/fpdfsdk/pdfwindow/PWL_ComboBox.h +++ b/fpdfsdk/pdfwindow/PWL_ComboBox.h @@ -7,6 +7,8 @@ #ifndef FPDFSDK_PDFWINDOW_PWL_COMBOBOX_H_ #define FPDFSDK_PDFWINDOW_PWL_COMBOBOX_H_ +#include + #include "fpdfsdk/pdfwindow/PWL_Edit.h" #include "fpdfsdk/pdfwindow/PWL_ListBox.h" #include "fpdfsdk/pdfwindow/PWL_Wnd.h" @@ -47,9 +49,9 @@ class CPWL_CBButton : public CPWL_Wnd { class CPWL_ComboBox : public CPWL_Wnd { public: CPWL_ComboBox(); - ~CPWL_ComboBox() override {} + ~CPWL_ComboBox() override; - CPWL_Edit* GetEdit() const { return m_pEdit; } + CPWL_Edit* GetEdit() const { return m_pEdit.get(); } // CPWL_Wnd: CFX_ByteString GetClassName() const override; @@ -90,9 +92,9 @@ class CPWL_ComboBox : public CPWL_Wnd { void CreateListBox(const PWL_CREATEPARAM& cp); void SetPopup(bool bPopup); - CPWL_CBEdit* m_pEdit; - CPWL_CBButton* m_pButton; - CPWL_CBListBox* m_pList; + std::unique_ptr m_pEdit; + std::unique_ptr m_pButton; + std::unique_ptr m_pList; bool m_bPopup; CFX_FloatRect m_rcOldWindow; int32_t m_nPopupWhere; -- cgit v1.2.3