From 7bef7c8bf8691174653bd734de4cf187dcf08648 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Wed, 31 May 2017 23:52:00 -0700 Subject: Clarify IPWL_Filler_Notify::QueryWherePopup() parameters. Update implementation and caller, and clean up surrounding code. Change-Id: I40975f79a5d4f560d6a7ee0d327b2e97241d29bd Reviewed-on: https://pdfium-review.googlesource.com/6172 Reviewed-by: dsinclair Commit-Queue: Lei Zhang --- fpdfsdk/pdfwindow/PWL_Edit.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'fpdfsdk/pdfwindow/PWL_Edit.h') diff --git a/fpdfsdk/pdfwindow/PWL_Edit.h b/fpdfsdk/pdfwindow/PWL_Edit.h index 82c1f19629..6f8c37baa5 100644 --- a/fpdfsdk/pdfwindow/PWL_Edit.h +++ b/fpdfsdk/pdfwindow/PWL_Edit.h @@ -22,11 +22,13 @@ class IFX_Edit_UndoItem; class IPWL_Filler_Notify { public: virtual ~IPWL_Filler_Notify() {} + + // Must write to |bBottom| and |fPopupRet|. virtual void QueryWherePopup(void* pPrivateData, float fPopupMin, float fPopupMax, - int32_t& nRet, - float& fPopupRet) = 0; // nRet: (0:bottom 1:top) + bool* bBottom, + float* fPopupRet) = 0; virtual void OnBeforeKeyStroke(void* pPrivateData, CFX_WideString& strChange, const CFX_WideString& strChangeEx, -- cgit v1.2.3