From 224bc5a983a02c0da3ecc0ee55b6c8b1fe500980 Mon Sep 17 00:00:00 2001 From: dsinclair Date: Thu, 28 Apr 2016 11:04:51 -0700 Subject: Change bool type to fix warnings. Switching the Is{SHIFT|CTRL|ALT|}KeyDown methods to bool from FX_BOOL generated cfx_systemhandler.cpp(129): warning C4800: 'FX_BOOL': forcing value to bool 'true' or 'false' (performance warning) on the win_chromium_x64_rel_ng and win8_chromium_ng bots. This CL switches back to FX_BOOL. Attempting to move everything to bool has huge ripple effects. I removed IsINSERTKeyDown as it was always false. Review-Url: https://codereview.chromium.org/1929963002 --- fpdfsdk/pdfwindow/PWL_EditCtrl.cpp | 2 -- 1 file changed, 2 deletions(-) (limited to 'fpdfsdk/pdfwindow/PWL_EditCtrl.cpp') diff --git a/fpdfsdk/pdfwindow/PWL_EditCtrl.cpp b/fpdfsdk/pdfwindow/PWL_EditCtrl.cpp index a6596582de..23349b46bc 100644 --- a/fpdfsdk/pdfwindow/PWL_EditCtrl.cpp +++ b/fpdfsdk/pdfwindow/PWL_EditCtrl.cpp @@ -284,8 +284,6 @@ FX_BOOL CPWL_EditCtrl::OnChar(uint16_t nChar, uint32_t nFlag) { case FWL_VKEY_Unknown: break; default: - if (IsINSERTpressed(nFlag)) - Delete(); InsertWord(word, GetCharSet()); break; } -- cgit v1.2.3