From a9a582b226961d16af302f72a3354c4e99c013f3 Mon Sep 17 00:00:00 2001
From: Tom Sepez <tsepez@chromium.org>
Date: Fri, 26 Oct 2018 23:04:45 +0000
Subject: Convert CPWL_Wnd::m_Children to vector of unique_ptr.

Still some lurking ownership issues.

Remove checks for null children, since the only way a child
gets into this vector is by AddChild(), and that does not
operate successfully on null arguments (tries to set the
parent in the child).

Change-Id: Ic0be6da05d7f7bb8bf1bd19ae6ae0580d2362dfc
Reviewed-on: https://pdfium-review.googlesource.com/c/44696
Commit-Queue: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
---
 fpdfsdk/pwl/cpwl_wnd.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'fpdfsdk/pwl/cpwl_wnd.h')

diff --git a/fpdfsdk/pwl/cpwl_wnd.h b/fpdfsdk/pwl/cpwl_wnd.h
index 7f6bfec813..51e34a769d 100644
--- a/fpdfsdk/pwl/cpwl_wnd.h
+++ b/fpdfsdk/pwl/cpwl_wnd.h
@@ -306,7 +306,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable<CPWL_Wnd> {
   CreateParams m_CreationParams;
   std::unique_ptr<PrivateData> m_pAttachedData;
   UnownedPtr<CPWL_Wnd> m_pParent;
-  std::vector<CPWL_Wnd*> m_Children;
+  std::vector<std::unique_ptr<CPWL_Wnd>> m_Children;
   UnownedPtr<CPWL_ScrollBar> m_pVScrollBar;
   CFX_FloatRect m_rcWindow;
   CFX_FloatRect m_rcClip;
-- 
cgit v1.2.3