From 39cf6a765ae349242289ec3287eaf4d6c5fd57f8 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 4 Oct 2018 23:33:30 +0000 Subject: Change |virtual ~Foo(){}| to |virtual ~Foo()=default;| Otherwise code coverage flags the empty body as unreachable. Change-Id: Iee1d9a876d68276529c70d9b8c7a28276f271767 Reviewed-on: https://pdfium-review.googlesource.com/c/43514 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- fpdfsdk/pwl/cpwl_edit.h | 2 +- fpdfsdk/pwl/cpwl_edit_impl.h | 2 +- fpdfsdk/pwl/cpwl_wnd.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'fpdfsdk/pwl') diff --git a/fpdfsdk/pwl/cpwl_edit.h b/fpdfsdk/pwl/cpwl_edit.h index 849436a3e3..d890834aac 100644 --- a/fpdfsdk/pwl/cpwl_edit.h +++ b/fpdfsdk/pwl/cpwl_edit.h @@ -15,7 +15,7 @@ class IPWL_Filler_Notify { public: - virtual ~IPWL_Filler_Notify() {} + virtual ~IPWL_Filler_Notify() = default; // Must write to |bBottom| and |fPopupRet|. virtual void QueryWherePopup(CPWL_Wnd::PrivateData* pAttached, diff --git a/fpdfsdk/pwl/cpwl_edit_impl.h b/fpdfsdk/pwl/cpwl_edit_impl.h index 7f14ade66a..047286322f 100644 --- a/fpdfsdk/pwl/cpwl_edit_impl.h +++ b/fpdfsdk/pwl/cpwl_edit_impl.h @@ -96,7 +96,7 @@ class CPWL_EditImpl_Undo { class IFX_Edit_UndoItem { public: - virtual ~IFX_Edit_UndoItem() {} + virtual ~IFX_Edit_UndoItem() = default; virtual void Undo() = 0; virtual void Redo() = 0; diff --git a/fpdfsdk/pwl/cpwl_wnd.h b/fpdfsdk/pwl/cpwl_wnd.h index 1ed239ed85..cc6662be30 100644 --- a/fpdfsdk/pwl/cpwl_wnd.h +++ b/fpdfsdk/pwl/cpwl_wnd.h @@ -106,7 +106,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable { class ProviderIface : public Observable { public: - virtual ~ProviderIface() {} + virtual ~ProviderIface() = default; // get a matrix which map user space to CWnd client space virtual CFX_Matrix GetWindowMatrix(PrivateData* pAttached) = 0; @@ -114,7 +114,7 @@ class CPWL_Wnd : public CPWL_TimerHandler, public Observable { class FocusHandlerIface { public: - virtual ~FocusHandlerIface() {} + virtual ~FocusHandlerIface() = default; virtual void OnSetFocus(CPWL_Edit* pEdit) = 0; }; -- cgit v1.2.3