From 55865454c43fbc3b163cff166544ba0a060dcbc4 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Aug 2018 20:18:04 +0000 Subject: The final game: mark everything final. Then revert the ones that break compilation. Fix one IWYU noticed during presubmit. Change-Id: I881a8a72818e55dbc4816247e35ff5e3015194e7 Reviewed-on: https://pdfium-review.googlesource.com/41470 Reviewed-by: Lei Zhang Commit-Queue: Tom Sepez --- fpdfsdk/pwl/cpwl_appstream.cpp | 2 +- fpdfsdk/pwl/cpwl_caret.h | 2 +- fpdfsdk/pwl/cpwl_combo_box.h | 6 +++--- fpdfsdk/pwl/cpwl_edit.h | 2 +- fpdfsdk/pwl/cpwl_edit_impl.h | 14 +++++++------- fpdfsdk/pwl/cpwl_icon.h | 2 +- fpdfsdk/pwl/cpwl_scroll_bar.h | 4 ++-- fpdfsdk/pwl/cpwl_special_button.h | 6 +++--- fpdfsdk/pwl/cpwl_wnd.cpp | 2 +- 9 files changed, 20 insertions(+), 20 deletions(-) (limited to 'fpdfsdk/pwl') diff --git a/fpdfsdk/pwl/cpwl_appstream.cpp b/fpdfsdk/pwl/cpwl_appstream.cpp index 7d7f710f03..4175b8ef2a 100644 --- a/fpdfsdk/pwl/cpwl_appstream.cpp +++ b/fpdfsdk/pwl/cpwl_appstream.cpp @@ -92,7 +92,7 @@ class AutoClosedCommand { ByteString close_; }; -class AutoClosedQCommand : public AutoClosedCommand { +class AutoClosedQCommand final : public AutoClosedCommand { public: explicit AutoClosedQCommand(std::ostringstream* stream) : AutoClosedCommand(stream, kStateSaveOperator, kStateRestoreOperator) {} diff --git a/fpdfsdk/pwl/cpwl_caret.h b/fpdfsdk/pwl/cpwl_caret.h index d60a96419b..1f7c2b84d4 100644 --- a/fpdfsdk/pwl/cpwl_caret.h +++ b/fpdfsdk/pwl/cpwl_caret.h @@ -9,7 +9,7 @@ #include "fpdfsdk/pwl/cpwl_wnd.h" -class CPWL_Caret : public CPWL_Wnd { +class CPWL_Caret final : public CPWL_Wnd { public: CPWL_Caret(); ~CPWL_Caret() override; diff --git a/fpdfsdk/pwl/cpwl_combo_box.h b/fpdfsdk/pwl/cpwl_combo_box.h index a4e823c4dc..d3c55c2a64 100644 --- a/fpdfsdk/pwl/cpwl_combo_box.h +++ b/fpdfsdk/pwl/cpwl_combo_box.h @@ -14,7 +14,7 @@ #include "fpdfsdk/pwl/cpwl_list_box.h" #include "fpdfsdk/pwl/cpwl_wnd.h" -class CPWL_CBListBox : public CPWL_ListBox { +class CPWL_CBListBox final : public CPWL_ListBox { public: CPWL_CBListBox() {} ~CPWL_CBListBox() override {} @@ -28,7 +28,7 @@ class CPWL_CBListBox : public CPWL_ListBox { bool OnCharNotify(uint16_t nChar, uint32_t nFlag); }; -class CPWL_CBButton : public CPWL_Wnd { +class CPWL_CBButton final : public CPWL_Wnd { public: CPWL_CBButton() {} ~CPWL_CBButton() override {} @@ -40,7 +40,7 @@ class CPWL_CBButton : public CPWL_Wnd { bool OnLButtonUp(const CFX_PointF& point, uint32_t nFlag) override; }; -class CPWL_ComboBox : public CPWL_Wnd { +class CPWL_ComboBox final : public CPWL_Wnd { public: CPWL_ComboBox(); ~CPWL_ComboBox() override; diff --git a/fpdfsdk/pwl/cpwl_edit.h b/fpdfsdk/pwl/cpwl_edit.h index 4a17de49d4..f7429c9d2d 100644 --- a/fpdfsdk/pwl/cpwl_edit.h +++ b/fpdfsdk/pwl/cpwl_edit.h @@ -41,7 +41,7 @@ class IPWL_Filler_Notify { #endif // PDF_ENABLE_XFA }; -class CPWL_Edit : public CPWL_EditCtrl { +class CPWL_Edit final : public CPWL_EditCtrl { public: CPWL_Edit(); ~CPWL_Edit() override; diff --git a/fpdfsdk/pwl/cpwl_edit_impl.h b/fpdfsdk/pwl/cpwl_edit_impl.h index 8680885e63..743afae6b6 100644 --- a/fpdfsdk/pwl/cpwl_edit_impl.h +++ b/fpdfsdk/pwl/cpwl_edit_impl.h @@ -102,7 +102,7 @@ class IFX_Edit_UndoItem { virtual void Redo() = 0; }; -class CFXEU_InsertWord : public IFX_Edit_UndoItem { +class CFXEU_InsertWord final : public IFX_Edit_UndoItem { public: CFXEU_InsertWord(CPWL_EditImpl* pEdit, const CPVT_WordPlace& wpOldPlace, @@ -124,7 +124,7 @@ class CFXEU_InsertWord : public IFX_Edit_UndoItem { int32_t m_nCharset; }; -class CFXEU_InsertReturn : public IFX_Edit_UndoItem { +class CFXEU_InsertReturn final : public IFX_Edit_UndoItem { public: CFXEU_InsertReturn(CPWL_EditImpl* pEdit, const CPVT_WordPlace& wpOldPlace, @@ -142,7 +142,7 @@ class CFXEU_InsertReturn : public IFX_Edit_UndoItem { CPVT_WordPlace m_wpNew; }; -class CFXEU_Backspace : public IFX_Edit_UndoItem { +class CFXEU_Backspace final : public IFX_Edit_UndoItem { public: CFXEU_Backspace(CPWL_EditImpl* pEdit, const CPVT_WordPlace& wpOldPlace, @@ -164,7 +164,7 @@ class CFXEU_Backspace : public IFX_Edit_UndoItem { int32_t m_nCharset; }; -class CFXEU_Delete : public IFX_Edit_UndoItem { +class CFXEU_Delete final : public IFX_Edit_UndoItem { public: CFXEU_Delete(CPWL_EditImpl* pEdit, const CPVT_WordPlace& wpOldPlace, @@ -188,7 +188,7 @@ class CFXEU_Delete : public IFX_Edit_UndoItem { bool m_bSecEnd; }; -class CFXEU_Clear : public IFX_Edit_UndoItem { +class CFXEU_Clear final : public IFX_Edit_UndoItem { public: CFXEU_Clear(CPWL_EditImpl* pEdit, const CPVT_WordRange& wrSel, @@ -206,7 +206,7 @@ class CFXEU_Clear : public IFX_Edit_UndoItem { WideString m_swText; }; -class CFXEU_InsertText : public IFX_Edit_UndoItem { +class CFXEU_InsertText final : public IFX_Edit_UndoItem { public: CFXEU_InsertText(CPWL_EditImpl* pEdit, const CPVT_WordPlace& wpOldPlace, @@ -415,7 +415,7 @@ class CPWL_EditImpl_Iterator { CPDF_VariableText::Iterator* m_pVTIterator; }; -class CPWL_EditImpl_Provider : public CPDF_VariableText::Provider { +class CPWL_EditImpl_Provider final : public CPDF_VariableText::Provider { public: explicit CPWL_EditImpl_Provider(IPVT_FontMap* pFontMap); ~CPWL_EditImpl_Provider() override; diff --git a/fpdfsdk/pwl/cpwl_icon.h b/fpdfsdk/pwl/cpwl_icon.h index df88465a5a..2cb84ebcf6 100644 --- a/fpdfsdk/pwl/cpwl_icon.h +++ b/fpdfsdk/pwl/cpwl_icon.h @@ -13,7 +13,7 @@ #include "core/fxcrt/unowned_ptr.h" #include "fpdfsdk/pwl/cpwl_wnd.h" -class CPWL_Icon : public CPWL_Wnd { +class CPWL_Icon final : public CPWL_Wnd { public: CPWL_Icon(); ~CPWL_Icon() override; diff --git a/fpdfsdk/pwl/cpwl_scroll_bar.h b/fpdfsdk/pwl/cpwl_scroll_bar.h index 1437597fbe..0b63bf224d 100644 --- a/fpdfsdk/pwl/cpwl_scroll_bar.h +++ b/fpdfsdk/pwl/cpwl_scroll_bar.h @@ -42,7 +42,7 @@ enum PWL_SCROLLBAR_TYPE { SBT_HSCROLL, SBT_VSCROLL }; enum PWL_SBBUTTON_TYPE { PSBT_MIN, PSBT_MAX, PSBT_POS }; -class CPWL_SBButton : public CPWL_Wnd { +class CPWL_SBButton final : public CPWL_Wnd { public: CPWL_SBButton(PWL_SCROLLBAR_TYPE eScrollBarType, PWL_SBBUTTON_TYPE eButtonType); @@ -115,7 +115,7 @@ struct PWL_SCROLL_PRIVATEDATA { float fSmallStep; }; -class CPWL_ScrollBar : public CPWL_Wnd { +class CPWL_ScrollBar final : public CPWL_Wnd { public: explicit CPWL_ScrollBar(PWL_SCROLLBAR_TYPE sbType); ~CPWL_ScrollBar() override; diff --git a/fpdfsdk/pwl/cpwl_special_button.h b/fpdfsdk/pwl/cpwl_special_button.h index 076b5298ed..b980f84625 100644 --- a/fpdfsdk/pwl/cpwl_special_button.h +++ b/fpdfsdk/pwl/cpwl_special_button.h @@ -9,7 +9,7 @@ #include "fpdfsdk/pwl/cpwl_button.h" -class CPWL_PushButton : public CPWL_Button { +class CPWL_PushButton final : public CPWL_Button { public: CPWL_PushButton(); ~CPWL_PushButton() override; @@ -19,7 +19,7 @@ class CPWL_PushButton : public CPWL_Button { CFX_FloatRect GetFocusRect() const override; }; -class CPWL_CheckBox : public CPWL_Button { +class CPWL_CheckBox final : public CPWL_Button { public: CPWL_CheckBox(); ~CPWL_CheckBox() override; @@ -36,7 +36,7 @@ class CPWL_CheckBox : public CPWL_Button { bool m_bChecked; }; -class CPWL_RadioButton : public CPWL_Button { +class CPWL_RadioButton final : public CPWL_Button { public: CPWL_RadioButton(); ~CPWL_RadioButton() override; diff --git a/fpdfsdk/pwl/cpwl_wnd.cpp b/fpdfsdk/pwl/cpwl_wnd.cpp index 6b840f2bb2..1cd9461af4 100644 --- a/fpdfsdk/pwl/cpwl_wnd.cpp +++ b/fpdfsdk/pwl/cpwl_wnd.cpp @@ -39,7 +39,7 @@ CPWL_Wnd::CreateParams::CreateParams(const CreateParams& other) = default; CPWL_Wnd::CreateParams::~CreateParams() = default; -class CPWL_MsgControl : public Observable { +class CPWL_MsgControl final : public Observable { public: explicit CPWL_MsgControl(CPWL_Wnd* pWnd) : m_pCreatedWnd(pWnd) {} ~CPWL_MsgControl() {} -- cgit v1.2.3