From ff46aaf499edcf153ee2f57c7016587aa96dcfa0 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Mon, 27 Jul 2015 11:55:29 -0700 Subject: FX Bool considered harmful, part 3 Try to reland this patch after fixing underlying issues that caused it to be reverted. fx_system.h is the only manual edit. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1258093002 . --- fpdfsdk/src/fpdf_ext.cpp | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) (limited to 'fpdfsdk/src/fpdf_ext.cpp') diff --git a/fpdfsdk/src/fpdf_ext.cpp b/fpdfsdk/src/fpdf_ext.cpp index 0d8db417ac..741347474c 100644 --- a/fpdfsdk/src/fpdf_ext.cpp +++ b/fpdfsdk/src/fpdf_ext.cpp @@ -14,7 +14,7 @@ class CFSDK_UnsupportInfo_Adapter { public: CFSDK_UnsupportInfo_Adapter(UNSUPPORT_INFO* unsp_info){ m_unsp_info = unsp_info;} -// FX_BOOL NeedToPauseNow(); +// bool NeedToPauseNow(); void ReportError(int nErrorType); private: @@ -35,25 +35,25 @@ void FreeUnsupportInfo(void* pData) delete pAdapter; } -FX_BOOL FPDF_UnSupportError(int nError) +bool FPDF_UnSupportError(int nError) { CFSDK_UnsupportInfo_Adapter * pAdapter = (CFSDK_UnsupportInfo_Adapter *)CPDF_ModuleMgr::Get()->GetPrivateData((void *)FPDFSDK_UNSUPPORT_CALL); if(!pAdapter) - return FALSE; + return false; pAdapter->ReportError(nError); - return TRUE; + return true; } DLLEXPORT FPDF_BOOL STDCALL FSDK_SetUnSpObjProcessHandler(UNSUPPORT_INFO* unsp_info) { if (!unsp_info || unsp_info->version!=1) - return FALSE; + return false; CFSDK_UnsupportInfo_Adapter * pAdapter = new CFSDK_UnsupportInfo_Adapter(unsp_info); CPDF_ModuleMgr::Get()->SetPrivateData((void *)FPDFSDK_UNSUPPORT_CALL,pAdapter, &FreeUnsupportInfo); - return TRUE; + return true; } void CheckUnSupportAnnot(CPDF_Document * pDoc, CPDF_Annot* pPDFAnnot) @@ -104,7 +104,7 @@ void CheckUnSupportAnnot(CPDF_Document * pDoc, CPDF_Annot* pPDFAnnot) } -FX_BOOL CheckSharedForm(CXML_Element * pElement, CFX_ByteString cbName) +bool CheckSharedForm(CXML_Element * pElement, CFX_ByteString cbName) { int count = pElement->CountAttrs(); int i=0; @@ -143,10 +143,10 @@ FX_BOOL CheckSharedForm(CXML_Element * pElement, CFX_ByteString cbName) { CXML_Element * pChild = pElement->GetElement(i); if(CheckSharedForm(pChild, cbName)) - return TRUE; + return true; } } - return FALSE; + return false; } void CheckUnSupportError(CPDF_Document * pDoc, FX_DWORD err_code) @@ -206,7 +206,7 @@ void CheckUnSupportError(CPDF_Document * pDoc, FX_DWORD err_code) CheckSharedForm(pElement, "workflowType"); // XFA Forms - CPDF_InterForm * pInterForm = new CPDF_InterForm(pDoc,FALSE); + CPDF_InterForm * pInterForm = new CPDF_InterForm(pDoc,false); if (pInterForm->HasXFAForm()) { FPDF_UnSupportError(FPDF_UNSP_DOC_XFAFORM); -- cgit v1.2.3