From cb78ef507c272488fd7e4fd6862014333d8a9de5 Mon Sep 17 00:00:00 2001 From: Lei Zhang Date: Fri, 2 Oct 2015 10:10:49 -0700 Subject: XFA: Remove checks for new returning NULL in fpdfsdk. Based on parts of https://codereview.chromium.org/1089823004 R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1383933003 . --- fpdfsdk/src/fpdfview.cpp | 21 +++------------------ 1 file changed, 3 insertions(+), 18 deletions(-) (limited to 'fpdfsdk/src/fpdfview.cpp') diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp index 414ade7070..47da1f49de 100644 --- a/fpdfsdk/src/fpdfview.cpp +++ b/fpdfsdk/src/fpdfview.cpp @@ -265,8 +265,7 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadDocument(FPDF_STRING file_path, return NULL; CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance(); - CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider); - return pDocument; + return new CPDFXFA_Document(pPDFDoc, pProvider); } DLLEXPORT FPDF_BOOL STDCALL FPDF_HasXFAField(FPDF_DOCUMENT document, @@ -351,8 +350,7 @@ DLLEXPORT FPDF_DOCUMENT STDCALL FPDF_LoadMemDocument(const void* data_buf, return NULL; CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance(); - CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider); - return pDocument; + return new CPDFXFA_Document(pPDFDoc, pProvider); } DLLEXPORT FPDF_DOCUMENT STDCALL @@ -375,8 +373,7 @@ FPDF_LoadCustomDocument(FPDF_FILEACCESS* pFileAccess, return NULL; CPDFXFA_App* pProvider = CPDFXFA_App::GetInstance(); - CPDFXFA_Document* pDocument = new CPDFXFA_Document(pPDFDoc, pProvider); - return pDocument; + return new CPDFXFA_Document(pPDFDoc, pProvider); } DLLEXPORT FPDF_BOOL STDCALL FPDF_GetFileVersion(FPDF_DOCUMENT doc, @@ -885,18 +882,6 @@ DLLEXPORT int STDCALL FPDF_GetPageSizeByIndex(FPDF_DOCUMENT document, int page_index, double* width, double* height) { - // CPDF_Document* pDoc = (CPDF_Document*)document; - // if(pDoc == NULL) - // return FALSE; - // - // CPDF_Dictionary* pDict = pDoc->GetPage(page_index); - // if (pDict == NULL) return FALSE; - // - // CPDF_Page page; - // page.Load(pDoc, pDict); - // *width = page.GetPageWidth(); - // *height = page.GetPageHeight(); - CPDFXFA_Document* pDoc = (CPDFXFA_Document*)document; if (pDoc == NULL) return FALSE; -- cgit v1.2.3