From ff8347a4b16f000be628c5e10d03a1e1c17537eb Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Wed, 17 Jun 2015 16:38:51 -0700 Subject: Replace some Release() calls with virtual destructors. A virtual method that does |delete this| is an anti-pattern. Some classes can be de-virtualized instead. Throw in some unique_ptrs and delete dead code for good measure. R=thestig@chromium.org Review URL: https://codereview.chromium.org/1192013002. --- fpdfsdk/src/fsdk_baseform.cpp | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'fpdfsdk/src/fsdk_baseform.cpp') diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp index f58bfd84f2..312d323581 100644 --- a/fpdfsdk/src/fsdk_baseform.cpp +++ b/fpdfsdk/src/fsdk_baseform.cpp @@ -1666,28 +1666,12 @@ CPDFSDK_InterForm::CPDFSDK_InterForm(CPDFSDK_Document* pDocument) CPDFSDK_InterForm::~CPDFSDK_InterForm() { - ASSERT(m_pInterForm != NULL); delete m_pInterForm; m_pInterForm = NULL; m_Map.RemoveAll(); } -void CPDFSDK_InterForm::Destroy() -{ - delete this; -} - -CPDF_InterForm* CPDFSDK_InterForm::GetInterForm() -{ - return m_pInterForm; -} - -CPDFSDK_Document* CPDFSDK_InterForm::GetDocument() -{ - return m_pDocument; -} - FX_BOOL CPDFSDK_InterForm::HighlightWidgets() { return FALSE; -- cgit v1.2.3