From 953f5c5f3858ce20ea5f28e0045c201148fba036 Mon Sep 17 00:00:00 2001 From: Raymes Khoury Date: Thu, 1 Oct 2015 15:12:08 +1000 Subject: Revert "Leak per-isolate data in pdfium" This reverts commit 3e144b8c23d7c52ed36329e87f0cb01f38ec1ed7. This may be causing the failures seen in crbug.com/537799. BUG=537799 Review URL: https://codereview.chromium.org/1382433003 . --- fpdfsdk/src/javascript/JS_Runtime.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) (limited to 'fpdfsdk/src/javascript/JS_Runtime.cpp') diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp index 7ce8a5343b..1e1486df5c 100644 --- a/fpdfsdk/src/javascript/JS_Runtime.cpp +++ b/fpdfsdk/src/javascript/JS_Runtime.cpp @@ -63,13 +63,7 @@ CJS_Runtime::~CJS_Runtime() { delete m_ContextArray.GetAt(i); m_ContextArray.RemoveAll(); - - // TODO(raymes): Currently we're freeing per-isolate data everytime a - // document is destroyed even though it may be in use by other documents. For - // now we leak the per-isolate data (when m_isolateManaged is false) until - // crbug.com/531339 is fixed. - if (m_isolateManaged) - FXJS_ReleaseRuntime(GetIsolate(), m_context); + FXJS_ReleaseRuntime(GetIsolate(), m_context); m_pApp = NULL; m_pDocument = NULL; -- cgit v1.2.3