From 3fea540931b6b2c700c50809a3d4d8a506f4f797 Mon Sep 17 00:00:00 2001 From: Jochen Eisinger Date: Tue, 19 May 2015 00:33:06 +0200 Subject: Replace v8::Handle with v8::Local and v8::Persistent with v8::Global those types are just aliases, and we should consistently use the new version R=tsepez@chromium.org BUG= Review URL: https://codereview.chromium.org/1138823004 --- fpdfsdk/src/javascript/JS_Value.cpp | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) (limited to 'fpdfsdk/src/javascript/JS_Value.cpp') diff --git a/fpdfsdk/src/javascript/JS_Value.cpp b/fpdfsdk/src/javascript/JS_Value.cpp index d3de6d1719..0943802508 100644 --- a/fpdfsdk/src/javascript/JS_Value.cpp +++ b/fpdfsdk/src/javascript/JS_Value.cpp @@ -15,7 +15,7 @@ CJS_Value::CJS_Value(v8::Isolate* isolate) : m_eType(VT_unknown),m_isolate(isolate) { } -CJS_Value::CJS_Value(v8::Isolate* isolate, v8::Handle pValue,FXJSVALUETYPE t) : +CJS_Value::CJS_Value(v8::Isolate* isolate, v8::Local pValue,FXJSVALUETYPE t) : m_pValue(pValue), m_eType(t), m_isolate(isolate) { } @@ -76,7 +76,7 @@ CJS_Value::~CJS_Value() { } -void CJS_Value::Attach(v8::Handle pValue,FXJSVALUETYPE t) +void CJS_Value::Attach(v8::Local pValue,FXJSVALUETYPE t) { m_pValue = pValue; m_eType = t; @@ -90,7 +90,7 @@ void CJS_Value::Attach(CJS_Value *pValue) void CJS_Value::Detach() { - m_pValue = v8::Handle(); + m_pValue = v8::Local(); m_eType = VT_unknown; } @@ -118,11 +118,11 @@ float CJS_Value::ToFloat() const CJS_Object* CJS_Value::ToCJSObject() const { - v8::Handle pObj = JS_ToObject(m_isolate, m_pValue); + v8::Local pObj = JS_ToObject(m_isolate, m_pValue); return (CJS_Object*)JS_GetPrivate(m_isolate, pObj); } -v8::Handle CJS_Value::ToV8Object() const +v8::Local CJS_Value::ToV8Object() const { return JS_ToObject(m_isolate, m_pValue); } @@ -137,16 +137,16 @@ CFX_ByteString CJS_Value::ToCFXByteString() const return CFX_ByteString::FromUnicode(ToCFXWideString()); } -v8::Handle CJS_Value::ToV8Value() const +v8::Local CJS_Value::ToV8Value() const { return m_pValue; } -v8::HandleCJS_Value::ToV8Array() const +v8::LocalCJS_Value::ToV8Array() const { if (IsArrayObject()) - return v8::Handle::Cast(JS_ToObject(m_isolate, m_pValue)); - return v8::Handle(); + return v8::Local::Cast(JS_ToObject(m_isolate, m_pValue)); + return v8::Local(); } /* ---------------------------------------------------------------------------------------- */ @@ -178,7 +178,7 @@ void CJS_Value::operator = (float fValue) m_eType = VT_number; } -void CJS_Value::operator =(v8::Handle pObj) +void CJS_Value::operator =(v8::Local pObj) { m_pValue = JS_NewObject(m_isolate,pObj); @@ -221,7 +221,7 @@ void CJS_Value::operator = (FX_LPCSTR pStr) void CJS_Value::operator = (CJS_Array & array) { - m_pValue = JS_NewObject2(m_isolate,(v8::Handle)array); + m_pValue = JS_NewObject2(m_isolate,(v8::Local)array); m_eType = VT_object; } @@ -461,7 +461,7 @@ void CJS_PropValue::operator<<(CJS_Date &date) CJS_Value::operator=(date); } -CJS_PropValue::operator v8::Handle() const +CJS_PropValue::operator v8::Local() const { return m_pValue; } @@ -475,7 +475,7 @@ CJS_Array::~CJS_Array() { } -void CJS_Array::Attach(v8::Handle pArray) +void CJS_Array::Attach(v8::Local pArray) { m_pArray = pArray; } @@ -489,7 +489,7 @@ void CJS_Array::GetElement(unsigned index,CJS_Value &value) { if (m_pArray.IsEmpty()) return; - v8::Handle p = JS_GetArrayElement(m_isolate, m_pArray,index); + v8::Local p = JS_GetArrayElement(m_isolate, m_pArray,index); value.Attach(p,VT_object); } @@ -508,7 +508,7 @@ int CJS_Array::GetLength() return JS_GetArrayLength(m_pArray); } -CJS_Array:: operator v8::Handle() +CJS_Array:: operator v8::Local() { if (m_pArray.IsEmpty()) m_pArray = JS_NewArray(m_isolate); @@ -549,7 +549,7 @@ FX_BOOL CJS_Date::IsValidDate() return !JS_PortIsNan(JS_ToNumber(m_isolate, m_pDate)); } -void CJS_Date::Attach(v8::Handle pDate) +void CJS_Date::Attach(v8::Local pDate) { m_pDate = pDate; } @@ -642,7 +642,7 @@ void CJS_Date::SetSeconds(int seconds) JS_ValueCopy(m_pDate,JS_NewDate(m_isolate,date)); } -CJS_Date::operator v8::Handle() +CJS_Date::operator v8::Local() { return m_pDate; } -- cgit v1.2.3