From 41f0590a9d7d627783a1b11c86808959928fc1a6 Mon Sep 17 00:00:00 2001 From: John Abd-El-Malek Date: Tue, 20 May 2014 09:52:29 -0700 Subject: Remove "using namespace v8" in header. This allows us to turn all warnings into errors. It also makes it clearer to find usage of v8 in the library. --- fpdfsdk/src/javascript/JS_Context.cpp | 4 ++-- fpdfsdk/src/javascript/JS_Object.cpp | 2 +- fpdfsdk/src/javascript/JS_Runtime.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) (limited to 'fpdfsdk/src/javascript') diff --git a/fpdfsdk/src/javascript/JS_Context.cpp b/fpdfsdk/src/javascript/JS_Context.cpp index 21acf59180..c0d4e0847e 100644 --- a/fpdfsdk/src/javascript/JS_Context.cpp +++ b/fpdfsdk/src/javascript/JS_Context.cpp @@ -116,7 +116,7 @@ FX_BOOL CJS_Context::DoJob(int nMode, const CFX_WideString& script, CFX_WideStri FX_BOOL CJS_Context::RunScript(const CFX_WideString& script, CFX_WideString& info) { v8::Isolate::Scope isolate_scope(m_pRuntime->GetIsolate()); - HandleScope handle_scope(m_pRuntime->GetIsolate()); + v8::HandleScope handle_scope(m_pRuntime->GetIsolate()); v8::Local context = m_pRuntime->NewJSContext(); v8::Context::Scope context_scope(context); @@ -126,7 +126,7 @@ FX_BOOL CJS_Context::RunScript(const CFX_WideString& script, CFX_WideString& inf FX_BOOL CJS_Context::Compile(const CFX_WideString& script, CFX_WideString& info) { v8::Isolate::Scope isolate_scope(m_pRuntime->GetIsolate()); - HandleScope handle_scope(m_pRuntime->GetIsolate()); + v8::HandleScope handle_scope(m_pRuntime->GetIsolate()); v8::Local context = m_pRuntime->NewJSContext(); v8::Context::Scope context_scope(context); diff --git a/fpdfsdk/src/javascript/JS_Object.cpp b/fpdfsdk/src/javascript/JS_Object.cpp index 07c5df2525..3830b2ac53 100644 --- a/fpdfsdk/src/javascript/JS_Object.cpp +++ b/fpdfsdk/src/javascript/JS_Object.cpp @@ -88,7 +88,7 @@ FX_BOOL CJS_EmbedObj::IsSafeMode(IFXJS_Context* cc) } /* --------------------------------- CJS_Object --------------------------------- */ -void FreeObject(const WeakCallbackData& data) +void FreeObject(const v8::WeakCallbackData& data) { CJS_Object* pJSObj = data.GetParameter(); if(pJSObj) diff --git a/fpdfsdk/src/javascript/JS_Runtime.cpp b/fpdfsdk/src/javascript/JS_Runtime.cpp index dc95d530f9..e707269da2 100644 --- a/fpdfsdk/src/javascript/JS_Runtime.cpp +++ b/fpdfsdk/src/javascript/JS_Runtime.cpp @@ -134,7 +134,7 @@ CJS_Runtime::~CJS_Runtime() FX_BOOL CJS_Runtime::InitJSObjects() { v8::Isolate::Scope isolate_scope(GetIsolate()); - HandleScope handle_scope(GetIsolate()); + v8::HandleScope handle_scope(GetIsolate()); v8::Handle context = v8::Context::New(GetIsolate()); v8::Context::Scope context_scope(context); //0 - 8 @@ -207,7 +207,7 @@ void CJS_Runtime::SetReaderDocument(CPDFSDK_Document* pReaderDoc) if (m_pDocument != pReaderDoc) { v8::Isolate::Scope isolate_scope(m_isolate); - HandleScope handle_scope(m_isolate); + v8::HandleScope handle_scope(m_isolate); v8::Local context =v8::Local::New(m_isolate, m_context); v8::Context::Scope context_scope(context); -- cgit v1.2.3