From ab54bc0f66ca3130ea4780580060f75f20c12234 Mon Sep 17 00:00:00 2001 From: Jochen Eisinger Date: Thu, 10 Sep 2015 13:46:08 +0200 Subject: Merge to XFA: Fix JS_GetArrayElement to not return an empty handle on success BUG=chromium:528376 TBR=ulan@chromium.org, tsepez@chromium.org Original Review URL: https://codereview.chromium.org/1337433002 . (cherry picked from commit 0d0935d3d6603dd7d851b1d5828635230f4c43ca) Review URL: https://codereview.chromium.org/1334633004 . --- fpdfsdk/src/jsapi/fxjs_v8.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'fpdfsdk/src/jsapi/fxjs_v8.cpp') diff --git a/fpdfsdk/src/jsapi/fxjs_v8.cpp b/fpdfsdk/src/jsapi/fxjs_v8.cpp index de957ed456..28ebfa29ad 100644 --- a/fpdfsdk/src/jsapi/fxjs_v8.cpp +++ b/fpdfsdk/src/jsapi/fxjs_v8.cpp @@ -748,7 +748,7 @@ v8::Local JS_GetArrayElement(IJS_Runtime* pJSRuntime, if (pArray.IsEmpty()) return v8::Local(); v8::Local val; - if (pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val)) + if (!pArray->Get(pJSRuntime->GetCurrentContext(), index).ToLocal(&val)) return v8::Local(); return val; } -- cgit v1.2.3