From c3f4894a6862c74b9ab32b4ec38c531de6ecd83c Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Wed, 19 Aug 2015 13:25:44 -0700 Subject: Extern in .cpp file is a code smell, part 2. Fixes the remaining issues, except for JBIG2/Skia ... R=thestig@chromium.org Review URL: https://codereview.chromium.org/1298393003 . --- fpdfsdk/src/fpdf_dataavail.cpp | 1 - fpdfsdk/src/fpdfview.cpp | 4 ---- fpdfsdk/src/fxedit/fxet_pageobjs.cpp | 5 ----- 3 files changed, 10 deletions(-) (limited to 'fpdfsdk/src') diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp index dddf9afb08..9ce298d0c5 100644 --- a/fpdfsdk/src/fpdf_dataavail.cpp +++ b/fpdfsdk/src/fpdf_dataavail.cpp @@ -7,7 +7,6 @@ #include "../../public/fpdf_dataavail.h" #include "../include/fsdk_define.h" -extern void ProcessParseError(FX_DWORD err_code); class CFPDF_FileAvailWrap : public IFX_FileAvail { public: CFPDF_FileAvailWrap() { m_pfileAvail = NULL; } diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp index bed00d3172..3603af6d91 100644 --- a/fpdfsdk/src/fpdfview.cpp +++ b/fpdfsdk/src/fpdfview.cpp @@ -61,10 +61,6 @@ FPDF_BOOL FSDK_IsSandBoxPolicyEnabled(FPDF_DWORD policy) { } } -#ifndef _T -#define _T(x) x -#endif - CCodec_ModuleMgr* g_pCodecModule = nullptr; #if _FX_OS_ == _FX_LINUX_EMBEDDED_ diff --git a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp index 1fb669bb57..9c18943a81 100644 --- a/fpdfsdk/src/fxedit/fxet_pageobjs.cpp +++ b/fpdfsdk/src/fxedit/fxet_pageobjs.cpp @@ -11,11 +11,6 @@ #define FX_EDIT_UNDERLINEHALFWIDTH 0.5f #define FX_EDIT_CROSSOUTHALFWIDTH 0.5f -extern CFX_ByteString GetPDFWordString(IFX_Edit_FontMap* pFontMap, - int32_t nFontIndex, - FX_WORD Word, - FX_WORD SubWord); - CPDF_Rect GetUnderLineRect(const CPVT_Word& word) { return CPDF_Rect(word.ptWord.x, word.ptWord.y + word.fDescent * 0.5f, word.ptWord.x + word.fWidth, -- cgit v1.2.3