From dc43b322915c5256a5a9458e6b8cd28bcecf91ae Mon Sep 17 00:00:00 2001 From: Bo Xu Date: Wed, 21 Jan 2015 14:20:28 -0800 Subject: Use signed long for FPDF_GetNamedDest buffer length. Need to have return value -1 indicating insufficient buffer. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/862163002 --- fpdfsdk/src/fpdfview.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fpdfsdk/src') diff --git a/fpdfsdk/src/fpdfview.cpp b/fpdfsdk/src/fpdfview.cpp index 87ef3ee5b2..3f6bdd94b3 100644 --- a/fpdfsdk/src/fpdfview.cpp +++ b/fpdfsdk/src/fpdfview.cpp @@ -817,7 +817,7 @@ DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDestByName(FPDF_DOCUMENT document,FPDF_ return name_tree.LookupNamedDest(pDoc, name); } -DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, void* buffer, unsigned long& buflen) +DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, void* buffer, long& buflen) { if (!buffer) buflen = 0; @@ -859,7 +859,7 @@ DLLEXPORT FPDF_DEST STDCALL FPDF_GetNamedDest(FPDF_DOCUMENT document, int index, } else if (buflen >= len) { memcpy(buffer, utf16Name.c_str(), len); } else { - len = -1; + buflen = -1; } return (FPDF_DEST)pDestObj; } -- cgit v1.2.3