From 219b3dab7e184bf8742f61527e37053b04903ff0 Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Thu, 5 Feb 2015 10:41:08 -0800 Subject: Fix segv in CPDF_DataAvail::CheckRoot() when /Root object is a string. Handles the case of this malformed PDF without crashing. Note that to get a reproducible test case, a small fix is applied to our .py script which results in some whitespace/numbering difs across the resources (down the road, we ought to generate them on the fly in an intermediate directory). BUG=454695 R=jun_fang@foxitsoftware.com, thestig@chromium.org Review URL: https://codereview.chromium.org/895933003 --- fpdfsdk/src/fpdfview_embeddertest.cpp | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'fpdfsdk') diff --git a/fpdfsdk/src/fpdfview_embeddertest.cpp b/fpdfsdk/src/fpdfview_embeddertest.cpp index 04549741ec..47119b5c52 100644 --- a/fpdfsdk/src/fpdfview_embeddertest.cpp +++ b/fpdfsdk/src/fpdfview_embeddertest.cpp @@ -190,3 +190,7 @@ TEST_F(FPDFViewEmbeddertest, Crasher_452455) { FPDF_PAGE page = LoadPage(0); EXPECT_NE(nullptr, page); } + +TEST_F(FPDFViewEmbeddertest, Crasher3) { + EXPECT_TRUE(OpenDocument("testing/resources/bug_454695.pdf")); +} -- cgit v1.2.3