From 55681f9c135c978cf4ca525dc1d26ff330e83029 Mon Sep 17 00:00:00 2001 From: Nico Weber Date: Wed, 30 Jul 2014 19:00:31 -0700 Subject: Remove a few unused variables, functions, and member variables. No intended behavior change. BUG=pdfium:29 R=bo_xu@foxitsoftware.com Review URL: https://codereview.chromium.org/426763003 --- fpdfsdk/include/formfiller/FFL_Notify.h | 1 - fpdfsdk/include/formfiller/FFL_TextField.h | 3 --- fpdfsdk/include/javascript/app.h | 1 - fpdfsdk/include/pdfwindow/PWL_Note.h | 1 - fpdfsdk/src/formfiller/FFL_Notify.cpp | 3 +-- fpdfsdk/src/formfiller/FFL_TextField.cpp | 2 +- fpdfsdk/src/javascript/PublicMethods.cpp | 2 +- fpdfsdk/src/javascript/app.cpp | 1 - fpdfsdk/src/pdfwindow/PWL_Note.cpp | 3 +-- 9 files changed, 4 insertions(+), 13 deletions(-) (limited to 'fpdfsdk') diff --git a/fpdfsdk/include/formfiller/FFL_Notify.h b/fpdfsdk/include/formfiller/FFL_Notify.h index c729b7452b..cabc1aa113 100644 --- a/fpdfsdk/include/formfiller/FFL_Notify.h +++ b/fpdfsdk/include/formfiller/FFL_Notify.h @@ -45,7 +45,6 @@ private: FX_BOOL ExecuteActionTree(CPDF_AAction::AActionType eAAT, CPDF_Action & action, FX_BOOL& bExit); FX_BOOL ExecuteAction(CPDF_AAction::AActionType eAAT,CPDF_Action & action,FX_BOOL& bExit); - CFFL_FormFiller * m_pFormFiller; FX_BOOL m_bDoActioning; FX_INT32 m_nNotifyFlag; }; diff --git a/fpdfsdk/include/formfiller/FFL_TextField.h b/fpdfsdk/include/formfiller/FFL_TextField.h index d2808e99c7..3a5fd688b0 100644 --- a/fpdfsdk/include/formfiller/FFL_TextField.h +++ b/fpdfsdk/include/formfiller/FFL_TextField.h @@ -25,9 +25,6 @@ public: virtual void Redo(); virtual CFX_WideString GetDescr(); virtual void Release(); - -private: - CPWL_Edit* m_pEdit; }; struct FFL_TextFieldState diff --git a/fpdfsdk/include/javascript/app.h b/fpdfsdk/include/javascript/app.h index 6273a7d4c0..671b3581a5 100644 --- a/fpdfsdk/include/javascript/app.h +++ b/fpdfsdk/include/javascript/app.h @@ -167,7 +167,6 @@ public: private: bool m_bCalculate; - CJS_Runtime* m_pRuntime; bool m_bRuntimeHighLight; CFX_ArrayTemplate m_aTimer; diff --git a/fpdfsdk/include/pdfwindow/PWL_Note.h b/fpdfsdk/include/pdfwindow/PWL_Note.h index 7cc9e04ba9..b3f73581b1 100644 --- a/fpdfsdk/include/pdfwindow/PWL_Note.h +++ b/fpdfsdk/include/pdfwindow/PWL_Note.h @@ -347,7 +347,6 @@ private: CPDF_Rect m_rcCaption; FX_BOOL m_bEnalbleNotify; IPopup_Note* m_pPopupNote; - IPWL_NoteHandler* m_pNoteHandler; CFX_WideString m_sReplyString; }; diff --git a/fpdfsdk/src/formfiller/FFL_Notify.cpp b/fpdfsdk/src/formfiller/FFL_Notify.cpp index f6a2feb4a1..73ab5dbb85 100644 --- a/fpdfsdk/src/formfiller/FFL_Notify.cpp +++ b/fpdfsdk/src/formfiller/FFL_Notify.cpp @@ -15,11 +15,10 @@ //#pragma warning(disable: 4800) CFFL_Notify::CFFL_Notify(CFFL_FormFiller * pFormFiller) : - m_pFormFiller(pFormFiller), m_bDoActioning(FALSE), m_nNotifyFlag(0) { - ASSERT(m_pFormFiller != NULL); + ASSERT(pFormFiller != NULL); } CFFL_Notify::~CFFL_Notify() diff --git a/fpdfsdk/src/formfiller/FFL_TextField.cpp b/fpdfsdk/src/formfiller/FFL_TextField.cpp index 8cd62fa025..45c716280c 100644 --- a/fpdfsdk/src/formfiller/FFL_TextField.cpp +++ b/fpdfsdk/src/formfiller/FFL_TextField.cpp @@ -10,7 +10,7 @@ #include "../../include/formfiller/FFL_CBA_Fontmap.h" //#include "../include/FFL_Notify.h" -CFFL_EditUndoItem::CFFL_EditUndoItem(CPWL_Edit* pEdit) : m_pEdit(pEdit) +CFFL_EditUndoItem::CFFL_EditUndoItem(CPWL_Edit* pEdit) { } diff --git a/fpdfsdk/src/javascript/PublicMethods.cpp b/fpdfsdk/src/javascript/PublicMethods.cpp index e307f432d3..1bd980af14 100644 --- a/fpdfsdk/src/javascript/PublicMethods.cpp +++ b/fpdfsdk/src/javascript/PublicMethods.cpp @@ -1074,7 +1074,7 @@ FX_BOOL CJS_PublicMethods::AFNumber_Format(OBJ_METHOD_PARAMS) int iDec = params[0]; int iSepStyle = params[1]; int iNegStyle = params[2]; - int icurrStyle = params[3]; //it's no use! + // params[3] is iCurrStyle, it's not used. std::wstring wstrCurrency(params[4].operator CFX_WideString()); FX_BOOL bCurrencyPrepend = params[5]; diff --git a/fpdfsdk/src/javascript/app.cpp b/fpdfsdk/src/javascript/app.cpp index 0546be8f86..c9a9ef7017 100644 --- a/fpdfsdk/src/javascript/app.cpp +++ b/fpdfsdk/src/javascript/app.cpp @@ -120,7 +120,6 @@ IMPLEMENT_JS_CLASS(CJS_App,app) app::app(CJS_Object * pJSObject) : CJS_EmbedObj(pJSObject) , m_bCalculate(true), - m_pRuntime(NULL), m_bRuntimeHighLight(false) // m_pMenuHead(NULL) { diff --git a/fpdfsdk/src/pdfwindow/PWL_Note.cpp b/fpdfsdk/src/pdfwindow/PWL_Note.cpp index 5929a357c9..b04b0f5003 100644 --- a/fpdfsdk/src/pdfwindow/PWL_Note.cpp +++ b/fpdfsdk/src/pdfwindow/PWL_Note.cpp @@ -1213,8 +1213,7 @@ CPWL_Note::CPWL_Note(IPopup_Note* pPopupNote, IPWL_NoteNotify* pNoteNotify, IPWL m_rcCaption(0,0,0,0), m_pNoteNotify(pNoteNotify), m_bEnalbleNotify(TRUE), - m_pPopupNote(pPopupNote), - m_pNoteHandler(pNoteHandler) + m_pPopupNote(pPopupNote) { } -- cgit v1.2.3