From b1a59597db4b8ce3ffc34dbfda2fb1ecb80c2397 Mon Sep 17 00:00:00 2001 From: thestig Date: Thu, 14 Apr 2016 18:29:56 -0700 Subject: Simplify XFA event handling. - Avoid casting to void* - Don't bother firing events that no one listens for Review URL: https://codereview.chromium.org/1890563003 --- fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp | 4 +--- fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) (limited to 'fpdfsdk') diff --git a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp index 53068d345d..d55183751e 100644 --- a/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp +++ b/fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp @@ -521,9 +521,7 @@ void CPDFXFA_Document::PageViewEvent(CXFA_FFPageView* pPageView, void CPDFXFA_Document::WidgetEvent(CXFA_FFWidget* hWidget, CXFA_WidgetAcc* pWidgetData, - uint32_t dwEvent, - void* pParam, - void* pAdditional) { + uint32_t dwEvent) { if (m_iDocType != DOCTYPE_DYNAMIC_XFA || !hWidget) return; diff --git a/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h b/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h index 2d4311f55f..5ffeb21022 100644 --- a/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h +++ b/fpdfsdk/fpdfxfa/include/fpdfxfa_doc.h @@ -73,9 +73,7 @@ class CPDFXFA_Document : public IXFA_DocProvider { // dwEvent refer to XFA_WIDGETEVENT_XXX virtual void WidgetEvent(CXFA_FFWidget* hWidget, CXFA_WidgetAcc* pWidgetData, - uint32_t dwEvent, - void* pParam = NULL, - void* pAdditional = NULL); + uint32_t dwEvent); // return true if render it. virtual FX_BOOL RenderCustomWidget(CXFA_FFWidget* hWidget, -- cgit v1.2.3