From d24b97ee1d065eff482355ea3ff82be59bb528b1 Mon Sep 17 00:00:00 2001 From: Artem Strygin Date: Wed, 9 Aug 2017 18:50:59 +0300 Subject: Unify of saving documents. In the original code the method of writing of objects depends on a much unpredictable factors: as: 1) Is there an updated version of the at least one object in the document. 2) The password is changed. 3) Was this object loaded earlier. 4) The Object is compressed and document have a password. With these factors it is difficult to predict what will be the final file. To reduce volatility use only one method that works in all cases mentioned. This method is parse then serialize. Change-Id: I3d7dcadd10abffbad68d1f993f2dd60b039ed989 Reviewed-on: https://pdfium-review.googlesource.com/9572 Commit-Queue: Art Snake Reviewed-by: dsinclair --- fpdfsdk/fpdfannot_embeddertest.cpp | 6 +++--- fpdfsdk/fpdfsave_embeddertest.cpp | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'fpdfsdk') diff --git a/fpdfsdk/fpdfannot_embeddertest.cpp b/fpdfsdk/fpdfannot_embeddertest.cpp index 58a00067a7..66260bd8ac 100644 --- a/fpdfsdk/fpdfannot_embeddertest.cpp +++ b/fpdfsdk/fpdfannot_embeddertest.cpp @@ -863,11 +863,11 @@ TEST_F(FPDFAnnotEmbeddertest, GetSetStringValue) { // Open the saved annotation. #if _FXM_PLATFORM_ == _FXM_PLATFORM_APPLE_ - const char md5[] = "c35408717759562d1f8bf33d317483d2"; + const char md5[] = "4d64e61c9c0f8c60ab3cc3234bb73b1c"; #elif _FXM_PLATFORM_ == _FXM_PLATFORM_WINDOWS_ - const char md5[] = "4f64add0190ede63f7bb9eb1e2e83edb"; + const char md5[] = "0e3710ea6476f5bcba2cd39eb42d54e2"; #else - const char md5[] = "02e1c6adff8fee4aeabd91c2c2e4be43"; + const char md5[] = "831a3c465a56d2e0c89aef7bdf15306a"; #endif TestSaved(595, 842, md5); FPDF_ANNOTATION new_annot = FPDFPage_GetAnnot(m_SavedPage, 0); diff --git a/fpdfsdk/fpdfsave_embeddertest.cpp b/fpdfsdk/fpdfsave_embeddertest.cpp index 260fe0c2a6..54eb347302 100644 --- a/fpdfsdk/fpdfsave_embeddertest.cpp +++ b/fpdfsdk/fpdfsave_embeddertest.cpp @@ -21,14 +21,14 @@ TEST_F(FPDFSaveEmbedderTest, SaveSimpleDoc) { EXPECT_TRUE(OpenDocument("hello_world.pdf")); EXPECT_TRUE(FPDF_SaveAsCopy(document(), this, 0)); EXPECT_THAT(GetString(), testing::StartsWith("%PDF-1.7\r\n")); - EXPECT_EQ(843u, GetString().length()); + EXPECT_EQ(805u, GetString().length()); } TEST_F(FPDFSaveEmbedderTest, SaveSimpleDocWithVersion) { EXPECT_TRUE(OpenDocument("hello_world.pdf")); EXPECT_TRUE(FPDF_SaveWithVersion(document(), this, 0, 14)); EXPECT_THAT(GetString(), testing::StartsWith("%PDF-1.4\r\n")); - EXPECT_EQ(843u, GetString().length()); + EXPECT_EQ(805u, GetString().length()); } TEST_F(FPDFSaveEmbedderTest, SaveSimpleDocWithBadVersion) { EXPECT_TRUE(OpenDocument("hello_world.pdf")); -- cgit v1.2.3