From ebe865db548f768038186054fc0f1eb024565c43 Mon Sep 17 00:00:00 2001 From: Dan Sinclair Date: Tue, 21 Nov 2017 22:05:40 +0000 Subject: Cleanup CXFA_SubmitData This CL cleans up the CXFA_SubmitData methods by using returns instead of out-params, sets the correct return types and makes the methods const. Change-Id: I41fe8f59e450ca444b64c291ac4a0a199c7ad0cf Reviewed-on: https://pdfium-review.googlesource.com/19111 Reviewed-by: Henrique Nakashima Commit-Queue: dsinclair --- fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'fpdfsdk') diff --git a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp index 2c13b92d4e..000e1a904e 100644 --- a/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp +++ b/fpdfsdk/fpdfxfa/cpdfxfa_docenvironment.cpp @@ -900,8 +900,7 @@ bool CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, if (!pFormFillEnv) return false; - WideString csURL; - submitData.GetSubmitTarget(csURL); + WideString csURL = submitData.GetSubmitTarget(); if (csURL.IsEmpty()) { WideString ws; ws.FromLocal("Submit cancelled."); @@ -917,9 +916,9 @@ bool CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, int fileFlag = -1; switch (submitData.GetSubmitFormat()) { case XFA_ATTRIBUTEENUM_Xdp: { - WideString csContent; - submitData.GetSubmitXDPContent(csContent); + WideString csContent = submitData.GetSubmitXDPContent(); csContent.Trim(); + WideString space; space.FromLocal(" "); csContent = space + csContent + space; @@ -950,6 +949,7 @@ bool CPDFXFA_DocEnvironment::SubmitDataInternal(CXFA_FFDoc* hDoc, } if (!pFileHandler) return false; + if (csURL.Left(7).CompareNoCase(L"mailto:") == 0) { WideString csToAddress; WideString csCCAddress; -- cgit v1.2.3