From e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 19 Jun 2018 17:33:32 +0000 Subject: Move fxcrt::{Byte,Wide}Strings with std::move(). Remove some string copies in barcode that were noticed whilst looking for moves. Change-Id: Ieda34d00f633576ba1f0dca283dcdabfb36f236c Reviewed-on: https://pdfium-review.googlesource.com/35410 Reviewed-by: dsinclair Reviewed-by: Tom Sepez Commit-Queue: Tom Sepez --- fxbarcode/cbc_code128.cpp | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) (limited to 'fxbarcode/cbc_code128.cpp') diff --git a/fxbarcode/cbc_code128.cpp b/fxbarcode/cbc_code128.cpp index 7ba623542d..8e83e2251c 100644 --- a/fxbarcode/cbc_code128.cpp +++ b/fxbarcode/cbc_code128.cpp @@ -47,15 +47,12 @@ bool CBC_Code128::Encode(const WideStringView& contents) { if (contents.GetLength() % 2 && pWriter->GetType() == BC_CODE128_C) content += '0'; - WideString encodeContents = pWriter->FilterContents(content.AsStringView()); - m_renderContents = encodeContents; - ByteString byteString = encodeContents.UTF8Encode(); + m_renderContents = pWriter->FilterContents(content.AsStringView()); + ByteString byteString = m_renderContents.UTF8Encode(); std::unique_ptr data( pWriter->Encode(byteString, format, outWidth, outHeight)); - if (!data) - return false; - return pWriter->RenderResult(encodeContents.AsStringView(), data.get(), - outWidth); + return data && pWriter->RenderResult(m_renderContents.AsStringView(), + data.get(), outWidth); } bool CBC_Code128::RenderDevice(CFX_RenderDevice* device, -- cgit v1.2.3