From e005dc33c31a2e701e1af3a0a3e5775cabbf1ddd Mon Sep 17 00:00:00 2001 From: Tom Sepez Date: Tue, 19 Jun 2018 17:33:32 +0000 Subject: Move fxcrt::{Byte,Wide}Strings with std::move(). Remove some string copies in barcode that were noticed whilst looking for moves. Change-Id: Ieda34d00f633576ba1f0dca283dcdabfb36f236c Reviewed-on: https://pdfium-review.googlesource.com/35410 Reviewed-by: dsinclair Reviewed-by: Tom Sepez Commit-Queue: Tom Sepez --- fxbarcode/cbc_code39.cpp | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) (limited to 'fxbarcode/cbc_code39.cpp') diff --git a/fxbarcode/cbc_code39.cpp b/fxbarcode/cbc_code39.cpp index 9715c25828..52859e14c5 100644 --- a/fxbarcode/cbc_code39.cpp +++ b/fxbarcode/cbc_code39.cpp @@ -40,15 +40,12 @@ bool CBC_Code39::Encode(const WideStringView& contents) { int32_t outHeight = 0; auto* pWriter = GetOnedCode39Writer(); WideString filtercontents = pWriter->FilterContents(contents); - WideString renderContents = pWriter->RenderTextContents(contents); - m_renderContents = renderContents; + m_renderContents = pWriter->RenderTextContents(contents); ByteString byteString = filtercontents.UTF8Encode(); std::unique_ptr data( pWriter->Encode(byteString, format, outWidth, outHeight)); - if (!data) - return false; - return pWriter->RenderResult(renderContents.AsStringView(), data.get(), - outWidth); + return data && pWriter->RenderResult(m_renderContents.AsStringView(), + data.get(), outWidth); } bool CBC_Code39::RenderDevice(CFX_RenderDevice* device, -- cgit v1.2.3