From aa3a9cd82df9dff1ef136797259e606a39c18b75 Mon Sep 17 00:00:00 2001 From: Ryan Harrison Date: Tue, 29 Aug 2017 16:39:44 -0400 Subject: Convert int* references to FX_STRSIZE Through out the code base there are numerous places where variables are declared using a signed integer type when interacting with the string classes, since they assume that FX_STRSIZE is 'int'. As part of changing the underling type of FX_STRSIZE to be unsigned, these locations are being changed to use FX_STRSIZE. This is necessary as part of converting the type, but has been broken off into a separate CL, since it should be low risk. Some related cleanups that are low risk are included as part of this CL. BUG=pdfium:828 Change-Id: Ifaae54ad195ccde0fe8672f71271d29a6ebd65fd Reviewed-on: https://pdfium-review.googlesource.com/12210 Reviewed-by: Tom Sepez Reviewed-by: Henrique Nakashima Reviewed-by: dsinclair Commit-Queue: Ryan Harrison --- fxbarcode/oned/BC_OnedCode39Writer.cpp | 39 ++++++++++++++-------------------- 1 file changed, 16 insertions(+), 23 deletions(-) (limited to 'fxbarcode/oned/BC_OnedCode39Writer.cpp') diff --git a/fxbarcode/oned/BC_OnedCode39Writer.cpp b/fxbarcode/oned/BC_OnedCode39Writer.cpp index cd87231fdf..ba8769ed95 100644 --- a/fxbarcode/oned/BC_OnedCode39Writer.cpp +++ b/fxbarcode/oned/BC_OnedCode39Writer.cpp @@ -49,13 +49,11 @@ CBC_OnedCode39Writer::~CBC_OnedCode39Writer() {} bool CBC_OnedCode39Writer::CheckContentValidity( const CFX_WideStringC& contents) { - for (int32_t i = 0; i < contents.GetLength(); i++) { + for (FX_STRSIZE i = 0; i < contents.GetLength(); i++) { wchar_t ch = contents[i]; - if ((ch >= (wchar_t)'0' && ch <= (wchar_t)'9') || - (ch >= (wchar_t)'A' && ch <= (wchar_t)'Z') || ch == (wchar_t)'-' || - ch == (wchar_t)'.' || ch == (wchar_t)' ' || ch == (wchar_t)'*' || - ch == (wchar_t)'$' || ch == (wchar_t)'/' || ch == (wchar_t)'+' || - ch == (wchar_t)'%') { + if ((ch >= L'0' && ch <= L'9') || (ch >= L'A' && ch <= L'Z') || + ch == L'-' || ch == L'.' || ch == L' ' || ch == L'*' || ch == L'$' || + ch == L'/' || ch == L'+' || ch == L'%') { continue; } return false; @@ -66,9 +64,9 @@ bool CBC_OnedCode39Writer::CheckContentValidity( CFX_WideString CBC_OnedCode39Writer::FilterContents( const CFX_WideStringC& contents) { CFX_WideString filtercontents; - for (int32_t i = 0; i < contents.GetLength(); i++) { + for (FX_STRSIZE i = 0; i < contents.GetLength(); i++) { wchar_t ch = contents[i]; - if (ch == (wchar_t)'*' && (i == 0 || i == contents.GetLength() - 1)) { + if (ch == L'*' && (i == 0 || i == contents.GetLength() - 1)) { continue; } if (ch > 175) { @@ -77,11 +75,9 @@ CFX_WideString CBC_OnedCode39Writer::FilterContents( } else { ch = Upper(ch); } - if ((ch >= (wchar_t)'0' && ch <= (wchar_t)'9') || - (ch >= (wchar_t)'A' && ch <= (wchar_t)'Z') || ch == (wchar_t)'-' || - ch == (wchar_t)'.' || ch == (wchar_t)' ' || ch == (wchar_t)'*' || - ch == (wchar_t)'$' || ch == (wchar_t)'/' || ch == (wchar_t)'+' || - ch == (wchar_t)'%') { + if ((ch >= L'0' && ch <= L'9') || (ch >= L'A' && ch <= L'Z') || + ch == L'-' || ch == L'.' || ch == L' ' || ch == L'*' || ch == L'$' || + ch == L'/' || ch == L'+' || ch == L'%') { filtercontents += ch; } } @@ -91,21 +87,18 @@ CFX_WideString CBC_OnedCode39Writer::FilterContents( CFX_WideString CBC_OnedCode39Writer::RenderTextContents( const CFX_WideStringC& contents) { CFX_WideString renderContents; - for (int32_t i = 0; i < contents.GetLength(); i++) { + for (FX_STRSIZE i = 0; i < contents.GetLength(); i++) { wchar_t ch = contents[i]; - if (ch == (wchar_t)'*' && (i == 0 || i == contents.GetLength() - 1)) { + if (ch == L'*' && (i == 0 || i == contents.GetLength() - 1)) { continue; } if (ch > 175) { i++; continue; } - if ((ch >= (wchar_t)'0' && ch <= (wchar_t)'9') || - (ch >= (wchar_t)'A' && ch <= (wchar_t)'Z') || - (ch >= (wchar_t)'a' && ch <= (wchar_t)'z') || ch == (wchar_t)'-' || - ch == (wchar_t)'.' || ch == (wchar_t)' ' || ch == (wchar_t)'*' || - ch == (wchar_t)'$' || ch == (wchar_t)'/' || ch == (wchar_t)'+' || - ch == (wchar_t)'%') { + if ((ch >= L'0' && ch <= L'9') || (ch >= L'A' && ch <= L'Z') || + (ch >= L'a' && ch <= L'z') || ch == L'-' || ch == L'.' || ch == L' ' || + ch == L'*' || ch == L'$' || ch == L'/' || ch == L'+' || ch == L'%') { renderContents += ch; } } @@ -145,7 +138,7 @@ void CBC_OnedCode39Writer::ToIntArray(int32_t a, int8_t* toReturn) { } char CBC_OnedCode39Writer::CalcCheckSum(const CFX_ByteString& contents) { - int32_t length = contents.GetLength(); + FX_STRSIZE length = contents.GetLength(); if (length > 80) return '*'; @@ -183,7 +176,7 @@ uint8_t* CBC_OnedCode39Writer::EncodeImpl(const CFX_ByteString& contents, int32_t codeWidth = (wideStrideNum * m_iWideNarrRatio + narrStrideNum) * 2 + 1 + m_iContentLen; size_t len = strlen(ALPHABET_STRING); - for (int32_t j = 0; j < m_iContentLen; j++) { + for (FX_STRSIZE j = 0; j < m_iContentLen; j++) { for (size_t i = 0; i < len; i++) { if (ALPHABET_STRING[i] != encodedContents[j]) continue; -- cgit v1.2.3